[19054] Fix communication tests not runned #3614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@richiprosima Please test this |
|
Update: I've just realized that the tests may keep failing quielty, as far as the test output (pass/fail) seems to be taken from the Update: In fact, shared memory communication tests are not running even with this patch added. |
Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: Eduardo Ponz <[email protected]>
EduPonz
force-pushed
the
hotfix/communication_tests
branch
from
9c6500d to
440a512
Compare
EduPonz
changed the title
Signed-off-by: Eduardo Ponz <[email protected]>
|
@richiprosima please test this |
Signed-off-by: JesusPoderoso <[email protected]>
JesusPoderoso
force-pushed
the
hotfix/communication_tests
branch
from
fd4c03b to
81f8502
Compare
|
@richiprosima please test this |
EduPonz
approved these changes
Jun 26, 2023
roscan-tech
pushed a commit
to roscan-tech/Fast-DDS
that referenced
this pull request
Sep 6, 2024
* Refs #19054: Fix communication tests not runned Signed-off-by: JesusPoderoso <[email protected]> * Refs #19054: Clean before running the test Signed-off-by: Eduardo Ponz <[email protected]> * Refs #19054: Make test_wrapper.cmake a configurable file Signed-off-by: Eduardo Ponz <[email protected]> * Refs #19054: Fix missing python path Signed-off-by: JesusPoderoso <[email protected]> --------- Signed-off-by: JesusPoderoso <[email protected]> Signed-off-by: Eduardo Ponz <[email protected]> Co-authored-by: Eduardo Ponz <[email protected]> Signed-off-by: roscan-tech <[email protected]>
roscan-tech
pushed a commit
to roscan-tech/Fast-DDS
that referenced
this pull request
Sep 6, 2024
* Refs #19054: Fix communication tests not runned Signed-off-by: JesusPoderoso <[email protected]> * Refs #19054: Clean before running the test Signed-off-by: Eduardo Ponz <[email protected]> * Refs #19054: Make test_wrapper.cmake a configurable file Signed-off-by: Eduardo Ponz <[email protected]> * Refs #19054: Fix missing python path Signed-off-by: JesusPoderoso <[email protected]> --------- Signed-off-by: JesusPoderoso <[email protected]> Signed-off-by: Eduardo Ponz <[email protected]> Co-authored-by: Eduardo Ponz <[email protected]> Signed-off-by: roscan-tech <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The #2886 pull request introduced a change in testing that made communication tests fail quietly, shown as passed.
This PR update the dependency included and introduces the fast dds cli tool in the build env (only if compiling tests) to proceed as expected in the previous PR.
Contributor Checklist
versions.mdfile (if applicable).Reviewer Checklist