Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18825] Explicitly register type object in ContentFilteredTopicExample #3594

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

MiguelCompany
Copy link
Member

@MiguelCompany MiguelCompany commented Jun 15, 2023

Description

Improve user experience by explicitly registering the TypeObject and referencing the documentation.

@Mergifyio backport 2.10.x 2.9.x 2.6.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@MiguelCompany MiguelCompany added the no-test Skip CI tests if PR marked with this label label Jun 15, 2023
@MiguelCompany MiguelCompany added this to the v2.11.1 milestone Jun 15, 2023
Copy link

@xiayh1992 xiayh1992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good improve!

@EduPonz
Copy link

EduPonz commented Jul 6, 2023

@Mergifyio backport 2.10.x 2.9.x 2.6.x

@mergify
Copy link
Contributor

mergify bot commented Jul 6, 2023

@EduPonz
Copy link

EduPonz commented Jul 6, 2023

@richiprosima please test mac

@EduPonz
Copy link

EduPonz commented Jul 6, 2023

@Mergifyio backport rebase

@mergify
Copy link
Contributor

mergify bot commented Jul 6, 2023

backport rebase

❌ No backport have been created

  • Backport to branch rebase failed

GitHub error: Branch not found

@EduPonz
Copy link

EduPonz commented Jul 6, 2023

@Mergifyio rebase

@mergify
Copy link
Contributor

mergify bot commented Jul 6, 2023

rebase

❌ Unable to rebase: user EduPonz is unknown.

Please make sure EduPonz has logged in Mergify dashboard.

@EduPonz
Copy link

EduPonz commented Jul 6, 2023

@Mergifyio rebase

@mergify
Copy link
Contributor

mergify bot commented Jul 6, 2023

rebase

✅ Branch has been successfully rebased

@EduPonz EduPonz force-pushed the hotfix/content-filter-example-register-type-object branch from 92237c7 to ea9ff1e Compare July 6, 2023 10:06
@EduPonz EduPonz merged commit c2b2d4d into master Jul 6, 2023
@EduPonz EduPonz deleted the hotfix/content-filter-example-register-type-object branch July 6, 2023 12:40
mergify bot pushed a commit that referenced this pull request Jul 6, 2023
mergify bot pushed a commit that referenced this pull request Jul 6, 2023
mergify bot pushed a commit that referenced this pull request Jul 6, 2023
MiguelCompany added a commit that referenced this pull request Aug 8, 2023
#3659)

Signed-off-by: Miguel Company <[email protected]>
(cherry picked from commit c2b2d4d)

Co-authored-by: Miguel Company <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-test Skip CI tests if PR marked with this label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants