Add configuration by profile to AdvanceConfigurationExample [18694] #3554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLBuenoLopez
suggested changes
Jun 5, 2023
There was a problem hiding this comment.
- I think some changes in your local repository have made it to this PR. The commit and PR title states that the goal is to introduce XML configuration support in the AdvanceConfigurationExample, but the SecureHelloWorldExample and the HelloWorldExample are also modified and I think that was not your intention.
- Please, fix the uncrustify linter which is complaining in the AdvanceConfigurationExample main file.
- README has not been updated with this new option.
- Being an example, and thus oriented for user understanding, maybe we should add an XML configuration file so the user can check this functionality.
- Please, fill contributor checklist (marking as N/A those checks not applicable).
examples/cpp/dds/AdvancedConfigurationExample/arg_configuration.h
Outdated
Show resolved
Hide resolved
JLBuenoLopez
added
no-test
added 5 commits
June 13, 2023 15:37
Signed-off-by: jparisu <[email protected]>
Signed-off-by: jparisu <[email protected]>
Signed-off-by: jparisu <[email protected]>
Signed-off-by: jparisu <[email protected]>
Signed-off-by: jparisu <[email protected]>
jparisu
force-pushed
the
feature/advance-example-xml
branch
from
cfe2a82 to
7eed7f6
Compare
jparisu
changed the title
|
@richiprosima please test this |
JLBuenoLopez
suggested changes
Jun 13, 2023
Signed-off-by: jparisu <[email protected]>
|
@richiprosima please test this |
roscan-tech
pushed a commit
to roscan-tech/Fast-DDS
that referenced
this pull request
Sep 8, 2024
…Prosima#3554) * Add configuration by profile to AdvanceConfigurationExample Signed-off-by: jparisu <[email protected]> * fix args inconsistency Signed-off-by: jparisu <[email protected]> * Restore old files uploaded by mistake Signed-off-by: jparisu <[email protected]> * Add conf example file Signed-off-by: jparisu <[email protected]> * uncrustify Signed-off-by: jparisu <[email protected]> * apply suggestions Signed-off-by: jparisu <[email protected]> --------- Signed-off-by: jparisu <[email protected]> Signed-off-by: roscan-tech <[email protected]>
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new argument to AdvanceConfigurationExample that allows to configure a DomainParticipant from XML.
Description
Contributor Checklist
versions.mdfile (if applicable).Reviewer Checklist