-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17294] Honor allow_unauthenticated_participants flag (backport #3385) #3521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Refs #17294: Add communication Simple Test Signed-off-by: Mario Dominguez <[email protected]> * Refs #17294: Retrieve allow_unauthenticated_participants from governance rules Signed-off-by: Mario Dominguez <[email protected]> * Refs #17294: on_validation_failed() method on Security Manager. Honor allow_unauthenticated flag Signed-off-by: Mario Dominguez <[email protected]> * Refs #17294: EndpointSecurityAttributes false on construction. Dont take nothing for granted Signed-off-by: Mario Dominguez <[email protected]> * Refs #17294: Linter Signed-off-by: Mario Dominguez <[email protected]> * Refs #17294: BlackBox Tests Signed-off-by: Mario Dominguez <[email protected]> * Refs #17294: Fix exponential times when sending handshake request Signed-off-by: Mario Dominguez <[email protected]> * Refs #17294: Resolve to validation_failed if the number of handshake requests sent exceeds a limit Signed-off-by: Mario Dominguez <[email protected]> * Refs #17294: add notify_secure_endpoints flag to notifyAboveRemoteEndpoints() Signed-off-by: Mario Dominguez <[email protected]> * Refs #17294: add assign_secure_endpoints flag to EDP assignRemoteEndpoints() Signed-off-by: Mario Dominguez <[email protected]> * Refs #17294: add assign_secure_endpoints flag to WLP assignRemoteEndpoints() Signed-off-by: Mario Dominguez <[email protected]> * Refs #17294: honor allow_unauthenticated_participants if validation fails Signed-off-by: Mario Dominguez <[email protected]> * Refs #17294: Linter Signed-off-by: Mario Dominguez <[email protected]> * Refs #17294: remove extra header Signed-off-by: Mario Dominguez <[email protected]> * Refs #17294: Added suggested test case scenario Signed-off-by: Mario Dominguez <[email protected]> * Refs #17294: Fix Security Memory Leaks and Corrected Condition Signed-off-by: Mario Dominguez <[email protected]> --------- Signed-off-by: Mario Dominguez <[email protected]> (cherry picked from commit 9adaf25) # Conflicts: # include/fastdds/rtps/builtin/discovery/participant/PDPSimple.h # src/cpp/rtps/security/SecurityManager.cpp # src/cpp/rtps/security/SecurityManager.h # test/communication/CMakeLists.txt # test/unittest/rtps/security/SecurityHandshakeProcessTests.cpp # test/unittest/rtps/security/SecurityTests.cpp # test/unittest/rtps/security/SecurityValidationRemoteTests.cpp
12 tasks
Honor allow_unauthenticated_participants flag (#3385) * Refs #17294: Add communication Simple Test Signed-off-by: Mario Dominguez <[email protected]> * Refs #17294: Retrieve allow_unauthenticated_participants from governance rules Signed-off-by: Mario Dominguez <[email protected]> * Refs #17294: on_validation_failed() method on Security Manager. Honor allow_unauthenticated flag Signed-off-by: Mario Dominguez <[email protected]> * Refs #17294: EndpointSecurityAttributes false on construction. Dont take nothing for granted Signed-off-by: Mario Dominguez <[email protected]> * Refs #17294: Linter Signed-off-by: Mario Dominguez <[email protected]> * Refs #17294: BlackBox Tests Signed-off-by: Mario Dominguez <[email protected]> * Refs #17294: Fix exponential times when sending handshake request Signed-off-by: Mario Dominguez <[email protected]> * Refs #17294: Resolve to validation_failed if the number of handshake requests sent exceeds a limit Signed-off-by: Mario Dominguez <[email protected]> * Refs #17294: add notify_secure_endpoints flag to notifyAboveRemoteEndpoints() Signed-off-by: Mario Dominguez <[email protected]> * Refs #17294: add assign_secure_endpoints flag to EDP assignRemoteEndpoints() Signed-off-by: Mario Dominguez <[email protected]> * Refs #17294: add assign_secure_endpoints flag to WLP assignRemoteEndpoints() Signed-off-by: Mario Dominguez <[email protected]> * Refs #17294: honor allow_unauthenticated_participants if validation fails Signed-off-by: Mario Dominguez <[email protected]> * Refs #17294: Linter Signed-off-by: Mario Dominguez <[email protected]> * Refs #17294: remove extra header Signed-off-by: Mario Dominguez <[email protected]> * Refs #17294: Added suggested test case scenario Signed-off-by: Mario Dominguez <[email protected]> * Refs #17294: Fix Security Memory Leaks and Corrected Condition Signed-off-by: Mario Dominguez <[email protected]> --------- Signed-off-by: Mario Dominguez <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
@richiprosima please test this |
MiguelCompany
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #3385 done by Mergify.
Cherry-pick of 9adaf25 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refresh
will re-evaluate the rules@Mergifyio rebase
will rebase this PR on its base branch@Mergifyio update
will merge the base branch into this PR@Mergifyio backport <destination>
will backport this PR on<destination>
branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com