Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17294] Honor allow_unauthenticated_participants flag (backport #3385) #3521

Merged
merged 4 commits into from
May 25, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented May 18, 2023

This is an automatic backport of pull request #3385 done by Mergify.
Cherry-pick of 9adaf25 has failed:

On branch mergify/bp/2.9.x/pr-3385
Your branch is up to date with 'origin/2.9.x'.

You are currently cherry-picking commit 9adaf251b.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   include/fastdds/rtps/builtin/discovery/endpoint/EDP.h
	modified:   include/fastdds/rtps/builtin/discovery/endpoint/EDPSimple.h
	modified:   include/fastdds/rtps/builtin/discovery/endpoint/EDPStatic.h
	modified:   include/fastdds/rtps/builtin/discovery/participant/PDP.h
	modified:   include/fastdds/rtps/builtin/liveliness/WLP.h
	modified:   include/fastdds/rtps/security/accesscontrol/EndpointSecurityAttributes.h
	modified:   src/cpp/rtps/builtin/discovery/endpoint/EDPSimple.cpp
	modified:   src/cpp/rtps/builtin/discovery/endpoint/EDPStatic.cpp
	modified:   src/cpp/rtps/builtin/discovery/participant/PDPClient.cpp
	modified:   src/cpp/rtps/builtin/discovery/participant/PDPClient.h
	modified:   src/cpp/rtps/builtin/discovery/participant/PDPListener.cpp
	modified:   src/cpp/rtps/builtin/discovery/participant/PDPServer.cpp
	modified:   src/cpp/rtps/builtin/discovery/participant/PDPServer.hpp
	modified:   src/cpp/rtps/builtin/discovery/participant/PDPServerListener.cpp
	modified:   src/cpp/rtps/builtin/discovery/participant/PDPSimple.cpp
	modified:   src/cpp/rtps/builtin/discovery/participant/timedevent/DSClientEvent.cpp
	modified:   src/cpp/rtps/builtin/liveliness/WLP.cpp
	modified:   src/cpp/security/accesscontrol/Permissions.cpp
	modified:   src/cpp/security/authentication/PKIDH.cpp
	modified:   test/blackbox/common/BlackboxTestsSecurity.cpp
	new file:   test/certs/certs/AE7BAD8C075AEAF8.pem
	new file:   test/certs/ecdsaparam
	new file:   test/certs/governance_allow_unauth_all_disabled_access_none.smime
	new file:   test/certs/governance_allow_unauth_all_disabled_access_none.xml
	new file:   test/certs/governance_allow_unauth_all_disabled_access_none_other_ca.smime
	new file:   test/certs/governance_allow_unauth_all_disabled_read_write_enabled.smime
	new file:   test/certs/governance_allow_unauth_all_disabled_read_write_enabled.xml
	new file:   test/certs/governance_allow_unauth_all_disabled_read_write_enabled_other_ca.smime
	new file:   test/certs/governance_allow_unauth_rtps_encrypt.smime
	new file:   test/certs/governance_allow_unauth_rtps_encrypt.xml
	new file:   test/certs/index_other.txt
	new file:   test/certs/othercacert.pem
	new file:   test/certs/othercacert.txt
	new file:   test/certs/othercaconf.cnf
	new file:   test/certs/othercakey.pem
	new file:   test/certs/othersub.cnf
	new file:   test/certs/othersubcert.pem
	new file:   test/certs/othersubcert.txt
	new file:   test/certs/othersubkey.pem
	new file:   test/certs/othersubreq.pem
	new file:   test/certs/permissions_helloworld_securehelloworld.smime
	new file:   test/certs/permissions_helloworld_securehelloworld.xml
	new file:   test/certs/permissions_helloworld_securehelloworld_other_ca.smime
	new file:   test/certs/permissions_helloworld_securehelloworld_other_ca.xml
	new file:   test/certs/serial_other
	new file:   test/communication/simple_allow_unauthenticated_sub_profile.xml
	new file:   test/communication/simple_secure_allow_unauthenticated_pub_profile.xml
	modified:   test/mock/rtps/PDP/fastdds/rtps/builtin/discovery/participant/PDP.h
	modified:   test/mock/rtps/PDPSimple/fastdds/rtps/builtin/discovery/participant/PDPSimple.h
	modified:   test/unittest/rtps/discovery/EdpTests.cpp

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   include/fastdds/rtps/builtin/discovery/participant/PDPSimple.h
	both modified:   src/cpp/rtps/security/SecurityManager.cpp
	both modified:   src/cpp/rtps/security/SecurityManager.h
	both modified:   test/communication/CMakeLists.txt
	both modified:   test/unittest/rtps/security/SecurityHandshakeProcessTests.cpp
	both modified:   test/unittest/rtps/security/SecurityTests.cpp
	both modified:   test/unittest/rtps/security/SecurityValidationRemoteTests.cpp

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

* Refs #17294: Add communication Simple Test

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #17294: Retrieve allow_unauthenticated_participants from governance rules

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #17294: on_validation_failed() method on Security Manager. Honor allow_unauthenticated flag

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #17294: EndpointSecurityAttributes false on construction. Dont take nothing for granted

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #17294: Linter

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #17294: BlackBox Tests

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #17294: Fix exponential times when sending handshake request

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #17294: Resolve to validation_failed if the number of handshake requests sent exceeds a limit

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #17294: add notify_secure_endpoints flag to notifyAboveRemoteEndpoints()

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #17294: add assign_secure_endpoints flag to EDP assignRemoteEndpoints()

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #17294: add assign_secure_endpoints flag to WLP assignRemoteEndpoints()

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #17294: honor allow_unauthenticated_participants if validation fails

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #17294: Linter

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #17294: remove extra header

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #17294: Added suggested test case scenario

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #17294: Fix Security Memory Leaks and Corrected Condition

Signed-off-by: Mario Dominguez <[email protected]>

---------

Signed-off-by: Mario Dominguez <[email protected]>
(cherry picked from commit 9adaf25)

# Conflicts:
#	include/fastdds/rtps/builtin/discovery/participant/PDPSimple.h
#	src/cpp/rtps/security/SecurityManager.cpp
#	src/cpp/rtps/security/SecurityManager.h
#	test/communication/CMakeLists.txt
#	test/unittest/rtps/security/SecurityHandshakeProcessTests.cpp
#	test/unittest/rtps/security/SecurityTests.cpp
#	test/unittest/rtps/security/SecurityValidationRemoteTests.cpp
@mergify mergify bot added the conflicts Backport PR wich git cherry pick failed label May 18, 2023
Honor allow_unauthenticated_participants flag (#3385)

* Refs #17294: Add communication Simple Test

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #17294: Retrieve allow_unauthenticated_participants from governance rules

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #17294: on_validation_failed() method on Security Manager. Honor allow_unauthenticated flag

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #17294: EndpointSecurityAttributes false on construction. Dont take nothing for granted

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #17294: Linter

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #17294: BlackBox Tests

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #17294: Fix exponential times when sending handshake request

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #17294: Resolve to validation_failed if the number of handshake requests sent exceeds a limit

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #17294: add notify_secure_endpoints flag to notifyAboveRemoteEndpoints()

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #17294: add assign_secure_endpoints flag to EDP assignRemoteEndpoints()

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #17294: add assign_secure_endpoints flag to WLP assignRemoteEndpoints()

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #17294: honor allow_unauthenticated_participants if validation fails

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #17294: Linter

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #17294: remove extra header

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #17294: Added suggested test case scenario

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #17294: Fix Security Memory Leaks and Corrected Condition

Signed-off-by: Mario Dominguez <[email protected]>

---------

Signed-off-by: Mario Dominguez <[email protected]>
@Mario-DL Mario-DL added ci-pending PR which CI is running and removed conflicts Backport PR wich git cherry pick failed labels May 24, 2023
Mario-DL added 2 commits May 24, 2023 09:00
Signed-off-by: Mario Dominguez <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
@Mario-DL
Copy link
Member

@richiprosima please test this

@JesusPoderoso JesusPoderoso added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels May 25, 2023
@MiguelCompany MiguelCompany merged commit 2605882 into 2.9.x May 25, 2023
@MiguelCompany MiguelCompany deleted the mergify/bp/2.9.x/pr-3385 branch May 25, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants