-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18431] Fix missing includes #3508
Conversation
Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with green build
Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
@richiprosima please test this |
Could this change be made to 2.10.x as well? In its current state, this prevents ROS2 from building on systems with GCC 13.1, as ROS2 specifically targets the 2.10.x branch. https://github.com/ros2/ros2/blob/rolling/ros2.repos |
@Mergifyio backport 2.9.x 2.6.x |
✅ Backports have been created
|
* Refs #18431: fix missing includes Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #18431: linters Signed-off-by: JLBuenoLopez-eProsima <[email protected]> --------- Signed-off-by: JLBuenoLopez-eProsima <[email protected]> (cherry picked from commit add29f4)
* Refs #18431: fix missing includes Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #18431: linters Signed-off-by: JLBuenoLopez-eProsima <[email protected]> --------- Signed-off-by: JLBuenoLopez-eProsima <[email protected]> (cherry picked from commit add29f4)
Could this get back ported to 2.6.4 as required by ros2 humble-release please |
@indeedhat, these changes have already been backported into 2.6.x in #3518. These changes will be included in the next patch release: 2.6.5. Until that moment, just build using 2.6.x branch or the commit that introduces the changes 02539b9. Fast DDS policy is not to change published releases. |
that makes sense, thanks |
the issue is a missing include similar to eProsima/Fast-DDS#3508
I think the same happens in the latest release v2.11.0, when building the statistics backend. To fix it, the following change was necessary.
|
Description
@Mergifyio backport 2.9.x 2.6.x 2.1.x
Fixes #3494
Contributor Checklist
versions.md
file (if applicable).Reviewer Checklist