[17961] Select correct listener for on_requested_deadline_missed (backport #3423) #3453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
10 tasks
|
@EduPonz, this backport has conflicts that should be solved. Can you take a look? |
EduPonz
force-pushed
the
mergify/bp/2.6.x/pr-3423
branch
from
a17b324 to
5a34bdc
Compare
* Refs #17961: Regression test for segfault Signed-off-by: Eduardo Ponz <[email protected]> * Refs #17961: Use the correct listener for deadline Signed-off-by: Eduardo Ponz <[email protected]> * Refs #17961: Fixed Windows warning regarding double to uint32 cast Signed-off-by: Javier Santiago <[email protected]> * Refs #17961: Test fix Signed-off-by: Mario Dominguez <[email protected]> --------- Signed-off-by: Eduardo Ponz <[email protected]> Signed-off-by: Javier Santiago <[email protected]> Signed-off-by: Mario Dominguez <[email protected]> Co-authored-by: Javier Santiago <[email protected]> Co-authored-by: Mario Dominguez <[email protected]> (cherry picked from commit 40411d9)
EduPonz
force-pushed
the
mergify/bp/2.6.x/pr-3423
branch
from
5a34bdc to
86182a4
Compare
EduPonz
added
needs-review
|
@richiprosima please test this |
|
@richiprosima please test windows MacOS CI failures are unrelated. I am concerned about the test failing in both Windows runs: |
|
@richiprosima please test windows |
|
CI failures are unrelated |
JLBuenoLopez
added
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #3423 done by Mergify.
Cherry-pick of 40411d9 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com