Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regular expression in XML schema #3421

Merged
merged 1 commit into from
Apr 3, 2023
Merged

Fix regular expression in XML schema #3421

merged 1 commit into from
Apr 3, 2023

Conversation

JesusPoderoso
Copy link
Contributor

@JesusPoderoso JesusPoderoso commented Mar 30, 2023 •
edited by MiguelCompany
Loading

Description

The scape sequence \, did not generate any conflicts with current validation, but it does with Xerces validation.

Dynamic types array dimension regular expression has been updated to reduce its lenght (there were redundant expressions) and also to remove the scape secuence \,.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@JesusPoderoso JesusPoderoso added the no-test Skip CI tests if PR marked with this label label Mar 30, 2023
@JesusPoderoso JesusPoderoso added this to the v2.10.1 milestone Mar 30, 2023
@JesusPoderoso
Fix regexp
db2ac44 
Signed-off-by: JesusPoderoso <[email protected]>
@JesusPoderoso JesusPoderoso force-pushed the hotfix/xml_schema_regexp branch from f68483a to db2ac44 Compare March 31, 2023 06:04
@JesusPoderoso JesusPoderoso changed the title Fix regular expresion in XML schema Fix regular expression in XML schema Mar 31, 2023
@JesusPoderoso JesusPoderoso added the needs-review PR that is ready to be reviewed label Mar 31, 2023
MRicoIE2CS
MRicoIE2CS approved these changes Mar 31, 2023
View reviewed changes
Copy link
Contributor

@MRicoIE2CS MRicoIE2CS left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@JesusPoderoso JesusPoderoso removed the no-test Skip CI tests if PR marked with this label label Mar 31, 2023
@JesusPoderoso
Copy link
Contributor Author

@richiprosima Please test this

@JesusPoderoso JesusPoderoso reopened this Mar 31, 2023
@JesusPoderoso JesusPoderoso added ci-pending PR which CI is running ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed needs-review PR that is ready to be reviewed ci-pending PR which CI is running labels Mar 31, 2023
@EduPonz EduPonz added ci-pending PR which CI is running and removed ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. labels Mar 31, 2023
@MiguelCompany MiguelCompany merged commit 2aa416d into master Apr 3, 2023
@MiguelCompany MiguelCompany deleted the hotfix/xml_schema_regexp branch April 3, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MRicoIE2CS MRicoIE2CS MRicoIE2CS approved these changes

Assignees
No one assigned
Labels
ci-pending PR which CI is running
Projects
None yet
Milestone
v2.10.1
Development

Successfully merging this pull request may close these issues.
4 participants
@JesusPoderoso @MRicoIE2CS @EduPonz @MiguelCompany