Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include the right header when building for iOS (backport #3002) #3401

Merged
merged 1 commit into from
Apr 13, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Mar 27, 2023

This is an automatic backport of pull request #3002 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

Signed-off-by: Lightech <[email protected]>
(cherry picked from commit c24bef2)
@EduPonz EduPonz added this to the v2.8.2 milestone Mar 27, 2023
@JLBuenoLopez
Copy link
Contributor

@richiprosima please test mac windows

@JLBuenoLopez JLBuenoLopez added the ci-pending PR which CI is running label Apr 11, 2023
@jsan-rt
Copy link
Contributor

jsan-rt commented Apr 12, 2023

@richiprosima please test windows

@jsan-rt jsan-rt added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Apr 12, 2023
@jsan-rt
Copy link
Contributor

jsan-rt commented Apr 12, 2023

Changes would only impact Apple devices if anything and Mac CI passed. Labeling as ready to merge.

@MiguelCompany MiguelCompany merged commit 1eab75f into 2.8.x Apr 13, 2023
@MiguelCompany MiguelCompany deleted the mergify/bp/2.8.x/pr-3002 branch April 13, 2023 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants