Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17290] Fix Fast DDS docs CI when workflow dispatch event #3355

Merged
merged 1 commit into from
Mar 16, 2023
Merged

[17290] Fix Fast DDS docs CI when workflow dispatch event #3355

merged 1 commit into from
Mar 16, 2023

Conversation

JesusPoderoso
Copy link
Contributor

@JesusPoderoso JesusPoderoso commented Mar 13, 2023 •
edited by MRicoIE2CS
Loading

Description

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Changes are ABI compatible.
  • N/A Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@JesusPoderoso JesusPoderoso marked this pull request as draft March 13, 2023 07:31
@JesusPoderoso JesusPoderoso added the in progress Issue or PR which is being reviewed label Mar 13, 2023
@JesusPoderoso JesusPoderoso force-pushed the hotfix/docs-ci branch 18 times, most recently from 1478962 to 7264421 Compare March 13, 2023 15:49
@JesusPoderoso JesusPoderoso added needs-review PR that is ready to be reviewed and removed in progress Issue or PR which is being reviewed labels Mar 13, 2023
@JesusPoderoso JesusPoderoso marked this pull request as ready for review March 13, 2023 16:11
@JesusPoderoso
Refs #17290: Initial setup
17ba8bf 
Signed-off-by: JesusPoderoso <[email protected]>
@MRicoIE2CS
Copy link
Contributor

@richiprosima please test this

@MRicoIE2CS MRicoIE2CS added the ci-pending PR which CI is running label Mar 15, 2023
@MRicoIE2CS MRicoIE2CS added this to the v2.10.0 milestone Mar 16, 2023
@MRicoIE2CS MRicoIE2CS removed needs-review PR that is ready to be reviewed ci-pending PR which CI is running labels Mar 16, 2023
@MRicoIE2CS MRicoIE2CS added the ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. label Mar 16, 2023
MRicoIE2CS
MRicoIE2CS approved these changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@MRicoIE2CS MRicoIE2CS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MiguelCompany MiguelCompany merged commit d33e814 into master Mar 16, 2023
@MiguelCompany MiguelCompany deleted the hotfix/docs-ci branch March 16, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MRicoIE2CS MRicoIE2CS MRicoIE2CS approved these changes

Assignees
No one assigned
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Milestone
v2.10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@JesusPoderoso @MRicoIE2CS @MiguelCompany