Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17297] Avoid creation of DynamicTypes on example #3335

Merged
merged 2 commits into from
Mar 6, 2023
Merged

[17297] Avoid creation of DynamicTypes on example #3335

merged 2 commits into from
Mar 6, 2023

Conversation

jsan-rt
Copy link
Contributor

@jsan-rt jsan-rt commented Feb 28, 2023 •
edited by JLBuenoLopez
Loading

Modified DynamicData example to be in line with eProsima's recommendations on entity creation inside callbacks (which we discourage).

Description

@Mergifyio backport 2.9.x 2.8.x 2.6.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • [NA] Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • [NA] Any new/modified methods have been properly documented using Doxygen.
  • [NA] Changes are ABI compatible.
  • [NA] Changes are API compatible.
  • [NA] New feature has been added to the versions.md file (if applicable).
  • [NA] New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@JLBuenoLopez JLBuenoLopez added this to the v2.10.0 milestone Mar 1, 2023
JLBuenoLopez
JLBuenoLopez previously approved these changes Mar 1, 2023
View reviewed changes
Copy link
Contributor

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a nitpick. I approve cause I am not against merging it as it is.

examples/cpp/dds/DynamicHelloWorldExample/HelloWorldSubscriber.h Outdated Show resolved Hide resolved
@JLBuenoLopez JLBuenoLopez added the skip-ci Automatically pass CI label Mar 1, 2023
@jsan-rt
Refs #17297: Added underscore
f100853 
Signed-off-by: Javier Santiago <[email protected]>
@JLBuenoLopez JLBuenoLopez added the ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. label Mar 1, 2023
@JLBuenoLopez
Copy link
Contributor

@Mergifyio backport 2.9.x 2.8.x 2.6.x

@mergify
Copy link
Contributor

mergify bot commented Mar 1, 2023 •
edited
Loading

backport 2.9.x 2.8.x 2.6.x

✅ Backports have been created

@EduPonz EduPonz merged commit 7fb237d into master Mar 6, 2023
@EduPonz EduPonz deleted the hotfix/dynamic_data_creation_on_cb branch March 6, 2023 06:52
@mergify mergify bot mentioned this pull request Mar 6, 2023
Merged
mergify bot pushed a commit that referenced this pull request Mar 6, 2023
@jsan-rt @mergify
Avoid creation of DynamicTypes on example (#3335)
2202d29 
* Refs #17297: Refactored the example to remove entity creation from callback

Signed-off-by: Javier Santiago <[email protected]>

* Refs #17297: Added underscore

Signed-off-by: Javier Santiago <[email protected]>

---------

Signed-off-by: Javier Santiago <[email protected]>
(cherry picked from commit 7fb237d)
@mergify mergify bot mentioned this pull request Mar 6, 2023
Merged
mergify bot pushed a commit that referenced this pull request Mar 6, 2023
@jsan-rt @mergify
Avoid creation of DynamicTypes on example (#3335)
94ab8df 
* Refs #17297: Refactored the example to remove entity creation from callback

Signed-off-by: Javier Santiago <[email protected]>

* Refs #17297: Added underscore

Signed-off-by: Javier Santiago <[email protected]>

---------

Signed-off-by: Javier Santiago <[email protected]>
(cherry picked from commit 7fb237d)
mergify bot pushed a commit that referenced this pull request Mar 6, 2023
@jsan-rt @mergify
Avoid creation of DynamicTypes on example (#3335)
e0d721e 
* Refs #17297: Refactored the example to remove entity creation from callback

Signed-off-by: Javier Santiago <[email protected]>

* Refs #17297: Added underscore

Signed-off-by: Javier Santiago <[email protected]>

---------

Signed-off-by: Javier Santiago <[email protected]>
(cherry picked from commit 7fb237d)
@mergify mergify bot mentioned this pull request Mar 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JLBuenoLopez JLBuenoLopez JLBuenoLopez approved these changes

Assignees
No one assigned
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. skip-ci Automatically pass CI
Projects
None yet
Milestone
v2.10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jsan-rt @JLBuenoLopez @EduPonz