[16360] Protect from uncaught exception during SHM Segment creation. (backport #3293) #3331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* Added regression test Signed-off-by: Javier Santiago <[email protected]> * Fix Segfault when SharedSegment::compute_per_allocation_extra_size throws Signed-off-by: Eduardo Ponz <[email protected]> * Refs #16360: Added comments and remove some unneeded code Signed-off-by: Javier Santiago <[email protected]> * Applied suggestions Signed-off-by: Javier Santiago <[email protected]> * Uncrustify Signed-off-by: Javier Santiago <[email protected]> * Fixed Windows warnings Signed-off-by: Javier Santiago <[email protected]> * Added NOMINMAX flag to test Signed-off-by: Javier Santiago <[email protected]> --------- Signed-off-by: Javier Santiago <[email protected]> Signed-off-by: Eduardo Ponz <[email protected]> Co-authored-by: Eduardo Ponz <[email protected]> (cherry picked from commit 72d1ba1)
9 tasks
|
@richiprosima please test discovery-server mac windows |
|
@richiprosima please test mac test windows |
|
@richiprosima please test windows |
JesusPoderoso
added
ready-to-merge
MiguelCompany
approved these changes
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #3293 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com