Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17125] Add milestone check to PR template. #3308

Merged
merged 2 commits into from
Feb 17, 2023
Merged

[17125] Add milestone check to PR template. #3308

merged 2 commits into from
Feb 17, 2023

Conversation

MiguelCompany
Copy link
Member

Description

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@MiguelCompany MiguelCompany added the skip-ci Automatically pass CI label Feb 16, 2023
@MiguelCompany MiguelCompany added this to the v2.10.0 milestone Feb 16, 2023
Mario-DL
Mario-DL approved these changes Feb 17, 2023
View reviewed changes
Copy link
Member

@Mario-DL Mario-DL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mario-DL Mario-DL added the ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. label Feb 17, 2023
@MiguelCompany MiguelCompany merged commit 1f8cbd5 into master Feb 17, 2023
@MiguelCompany MiguelCompany deleted the hotfix/milestone-on-checklist branch February 17, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mario-DL Mario-DL Mario-DL approved these changes

Assignees
No one assigned
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. skip-ci Automatically pass CI
Projects
None yet
Milestone
v2.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@MiguelCompany @Mario-DL