Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16909] Update pull request template #3248

Merged
merged 3 commits into from
Jan 27, 2023
Merged

[16909] Update pull request template #3248

merged 3 commits into from
Jan 27, 2023

Conversation

EduPonz
Copy link

@EduPonz EduPonz commented Jan 25, 2023 •
edited by JLBuenoLopez
Loading

Description

This PR updates the PR template so that the only test that are required for the contributor to have been run locally are those added in the PR.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added.
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Fast DDS test suite has been run locally.
  • N/A Changes are ABI compatible.
  • N/A Changes are API compatible.
  • N/A Documentation builds and tests pass locally.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@EduPonz EduPonz added the skip-ci Automatically pass CI label Jan 25, 2023
JLBuenoLopez
JLBuenoLopez reviewed Jan 25, 2023
View reviewed changes
Copy link
Contributor

@JLBuenoLopez JLBuenoLopez left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of nitpicks! Thanks @EduPonz 😄

.github/pull_request_template.md Outdated Show resolved Hide resolved
.github/pull_request_template.md Show resolved Hide resolved
JLBuenoLopez
JLBuenoLopez approved these changes Jan 25, 2023
View reviewed changes
Copy link
Contributor

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JLBuenoLopez JLBuenoLopez added the ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. label Jan 27, 2023
@EduPonz EduPonz merged commit 6a68664 into master Jan 27, 2023
@EduPonz EduPonz deleted the feature/update_pr_template branch January 27, 2023 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JLBuenoLopez JLBuenoLopez JLBuenoLopez approved these changes

Assignees
No one assigned
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. skip-ci Automatically pass CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EduPonz @JLBuenoLopez