Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve rediscovery on lossy environments [15165] (backport #2838) (backport #2858) #2875

Merged
merged 2 commits into from
Aug 2, 2022

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jul 22, 2022

This is an automatic backport of pull request #2858 done by Mergify.
Cherry-pick of 5d220ce has failed:

On branch mergify/bp/2.1.x/pr-2858
Your branch is up to date with 'origin/2.1.x'.

You are currently cherry-picking commit 5d220cec8.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   src/cpp/rtps/reader/WriterProxy.cpp
	both modified:   src/cpp/rtps/reader/WriterProxy.h
	both modified:   src/cpp/rtps/writer/StatefulWriter.cpp

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

* Refs #15096. Recursive initial ack

Signed-off-by: Ricardo González Moreno <[email protected]>

* Refs #15096. Initial ack starts periodic heartbeat

Signed-off-by: Ricardo González Moreno <[email protected]>

* Refs #15096. Little coding style change

Signed-off-by: Ricardo González Moreno <[email protected]>

* Refs #15096. Fix error with datasharing writers

Signed-off-by: Ricardo González Moreno <[email protected]>
(cherry picked from commit fb790b0)

Co-authored-by: Ricardo González <[email protected]>
(cherry picked from commit 5d220ce)

# Conflicts:
#	src/cpp/rtps/reader/WriterProxy.cpp
#	src/cpp/rtps/reader/WriterProxy.h
#	src/cpp/rtps/writer/StatefulWriter.cpp
@mergify mergify bot added the conflicts Backport PR wich git cherry pick failed label Jul 22, 2022
@MiguelCompany MiguelCompany added this to the v2.1.3 milestone Jul 22, 2022
@MiguelCompany
Copy link
Member

@richiware Would you mind solving the conflicts on this backport?

Signed-off-by: Ricardo González Moreno <[email protected]>
@richiware
Copy link
Member

@richiprosima Please test this

@MiguelCompany MiguelCompany removed to-do conflicts Backport PR wich git cherry pick failed labels Aug 2, 2022
@MiguelCompany
Copy link
Member

@richiprosima Please test mac

@MiguelCompany MiguelCompany merged commit a00453f into 2.1.x Aug 2, 2022
@MiguelCompany MiguelCompany deleted the mergify/bp/2.1.x/pr-2858 branch August 2, 2022 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants