Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add BitmapRange UT #2737

Merged
merged 2 commits into from
Jun 21, 2023
Merged

Add BitmapRange UT #2737

merged 2 commits into from
Jun 21, 2023

Conversation

dcoello-dev
Copy link
Contributor

@dcoello-dev dcoello-dev commented Jun 9, 2022 •
edited by EduPonz
Loading

Signed-off-by: David Coello Pulido [email protected]

Description

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added.
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • Fast DDS test suite has been run locally.
  • N/A Changes are ABI compatible.
  • N/A Changes are API compatible.
  • N/A Documentation builds and tests pass locally.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.

Reviewer Checklist

  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@dcoello-dev dcoello-dev requested a review from MiguelCompany June 9, 2022 08:52
@dcoello-dev dcoello-dev added the in progress Issue or PR which is being reviewed label Jun 9, 2022
@dcoello-dev dcoello-dev force-pushed the feature/add-BitmapRange-UTs branch from 9d6a99e to de66b54 Compare June 9, 2022 09:52
@JLBuenoLopez
Copy link
Contributor

@dcoello-dev What is the status of this PR? If it is ready to be merged, please assign milestone v2.10.1. If not, are we going to keep working on this? Otherwise, please close the PR. Thanks!

@JLBuenoLopez JLBuenoLopez added this to the v2.10.1 milestone Mar 16, 2023
@EduPonz EduPonz modified the milestones: v2.10.1, v2.10.2 Mar 31, 2023
@JLBuenoLopez JLBuenoLopez modified the milestones: v2.10.2, v2.11.0 Jun 12, 2023
@JLBuenoLopez
Copy link
Contributor

@richiprosima please test this

@MiguelCompany
Copy link
Member

@Mergifyio rebase

@dcoello-dev @MiguelCompany
Add BitmapRange UT
19f04b6 
Signed-off-by: David Coello Pulido <[email protected]>
@mergify
Copy link
Contributor

mergify bot commented Jun 14, 2023

rebase

✅ Branch has been successfully rebased

@MiguelCompany MiguelCompany force-pushed the feature/add-BitmapRange-UTs branch from de66b54 to 19f04b6 Compare June 14, 2023 10:44
@MiguelCompany
Fix signed/unsigned comparisons
6ba8116 
Signed-off-by: Miguel Company <[email protected]>
@MiguelCompany
Copy link
Member

@richiprosima Please test this

@MiguelCompany MiguelCompany added ci-pending PR which CI is running and removed in progress Issue or PR which is being reviewed labels Jun 14, 2023
@Mario-DL Mario-DL added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. ci-pending PR which CI is running and removed ci-pending PR which CI is running ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. labels Jun 20, 2023
@Mario-DL
Copy link
Member

@richiprosima please test windows

1 similar comment
@Mario-DL
Copy link
Member

@richiprosima please test windows

@Mario-DL Mario-DL added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Jun 21, 2023
@EduPonz EduPonz merged commit eacbb25 into master Jun 21, 2023
@EduPonz EduPonz deleted the feature/add-BitmapRange-UTs branch June 21, 2023 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

Assignees
No one assigned
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Milestone
v2.11.0
Development

Successfully merging this pull request may close these issues.
5 participants
@dcoello-dev @JLBuenoLopez @MiguelCompany @Mario-DL @EduPonz