Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14260] Fixed exported symbols on ContentFilteredTopic #2611

Merged
merged 2 commits into from
Jun 14, 2023
Merged

[14260] Fixed exported symbols on ContentFilteredTopic #2611

merged 2 commits into from
Jun 14, 2023

Conversation

MiguelCompany
Copy link
Member

@MiguelCompany MiguelCompany commented Mar 28, 2022 •
edited
Loading

Description

This PR fixes the exported symbols on ContentFilteredTopic

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added.
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Fast DDS test suite has been run locally.
  • Changes are NOT ABI compatible.
  • Changes are API compatible.
  • Documentation builds and tests pass locally.
  • New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.

Reviewer Checklist

  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@MiguelCompany MiguelCompany added the skip-ci Automatically pass CI label Mar 28, 2022
@MiguelCompany MiguelCompany added this to the v2.7.0 milestone Mar 28, 2022
@MiguelCompany MiguelCompany mentioned this pull request Mar 28, 2022
Merged
13 tasks
@EduPonz EduPonz added the to-do label Jun 10, 2022
@EduPonz EduPonz modified the milestones: v2.7.0, v2.7.1 Jul 1, 2022
@MiguelCompany MiguelCompany modified the milestones: v2.7.1, v2.8.0 Jul 22, 2022
@EduPonz EduPonz modified the milestones: v2.8.0, v2.9.0 Sep 26, 2022
@JLBuenoLopez JLBuenoLopez modified the milestones: v2.9.0, v2.10.0 Jan 26, 2023
@MiguelCompany MiguelCompany modified the milestones: v2.10.0, v2.11.0 Apr 1, 2023
JLBuenoLopez
JLBuenoLopez previously approved these changes Jun 13, 2023
View reviewed changes
Copy link
Contributor

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MiguelCompany MiguelCompany marked this pull request as ready for review June 13, 2023 09:54
@MiguelCompany MiguelCompany added no-test Skip CI tests if PR marked with this label and removed skip-ci Automatically pass CI to-do labels Jun 13, 2023
@JLBuenoLopez JLBuenoLopez added the ci-pending PR which CI is running label Jun 13, 2023
@MiguelCompany
Copy link
Member Author

@richiprosima Please test this

@JLBuenoLopez JLBuenoLopez added versions-pending and removed ci-pending PR which CI is running labels Jun 13, 2023
@MiguelCompany
Copy link
Member Author

@richiprosima Please test windows

@MiguelCompany MiguelCompany changed the title [14260] Fix dll exports. [14260] Fixed exported symbols on ContentFilteredTopic Jun 14, 2023
@MiguelCompany
Copy link
Member Author

@JLBuenoLopez-eProsima I rebased this one and updated versions.md

JLBuenoLopez
JLBuenoLopez approved these changes Jun 14, 2023
View reviewed changes
Copy link
Contributor

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JLBuenoLopez JLBuenoLopez added the ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. label Jun 14, 2023
@MiguelCompany MiguelCompany merged commit dbd3ba7 into master Jun 14, 2023
@MiguelCompany MiguelCompany deleted the bugfix/dll-exports branch June 14, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JLBuenoLopez JLBuenoLopez JLBuenoLopez approved these changes

Assignees
No one assigned
Labels
no-test Skip CI tests if PR marked with this label ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Milestone
v2.11.0
Development

Successfully merging this pull request may close these issues.
3 participants
@MiguelCompany @JLBuenoLopez @EduPonz