Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix not caught exception in XMLDynamicParser [13462] #2403

Merged
merged 1 commit into from
Jan 13, 2022

Conversation

richiware
Copy link
Member

@richiware richiware commented Jan 12, 2022

XMLDynamicParser uses stoi() without a try/catch statement. With a wrong XML attribute value a exception is launched without being caught.

This will fix oss-fuzz 43525

Signed-off-by: Ricardo González Moreno <[email protected]>
@richiware richiware changed the title Fix not caught exception in XMLDynamicParser Fix not caught exception in XMLDynamicParser [13462] Jan 12, 2022
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MiguelCompany MiguelCompany merged commit c3678e2 into master Jan 13, 2022
@MiguelCompany MiguelCompany deleted the bugfix/13454 branch January 13, 2022 06:10
@MiguelCompany
Copy link
Member

@Mergifyio backport 2.3.x

@mergify
Copy link
Contributor

mergify bot commented Oct 24, 2022

backport 2.3.x

✅ Backports have been created

MiguelCompany pushed a commit that referenced this pull request Oct 24, 2022
XMLDynamicParser uses stoi() without a try/catch statement. With a wrong XML attribute value a exception is launched without being caught.

This will fix oss-fuzz 43525

(cherry picked from commit c3678e2)

# Conflicts:
#	test/unittest/xmlparser/XMLParserTests.cpp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants