Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20501] Improve LARGE_DATA documentation (backport #671) #708

Merged
merged 2 commits into from
Mar 4, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Mar 1, 2024

This is an automatic backport of pull request #671 done by Mergify.
Cherry-pick of 2010219 has failed:

On branch mergify/bp/2.6.x/pr-671
Your branch is up to date with 'origin/2.6.x'.

You are currently cherry-picking commit 2010219.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   code/XMLTester.xml
	modified:   docs/fastdds/transport/tcp/tcp.rst
	modified:   docs/fastdds/troubleshooting/troubleshooting.rst
	modified:   docs/fastdds/use_cases/large_data/large_data.rst
	modified:   docs/fastdds/use_cases/tcp/tcp_with_multicast_discovery.rst

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   docs/fastdds/rtps_layer/rtps_layer.rst

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

* Add sockets recommendation to LARGE_DATA mode

Signed-off-by: cferreiragonz <[email protected]>

* Add environment variable to LARGE_DATA examples

Signed-off-by: cferreiragonz <[email protected]>

* Add LARGE_DATA to troubleshooting

Signed-off-by: cferreiragonz <[email protected]>

* Apply suggestions

Signed-off-by: cferreiragonz <[email protected]>

---------

Signed-off-by: cferreiragonz <[email protected]>
(cherry picked from commit 2010219)

# Conflicts:
#	docs/fastdds/rtps_layer/rtps_layer.rst
@mergify mergify bot added the conflicts label Mar 1, 2024
Copy link
Author

mergify bot commented Mar 1, 2024

Cherry-pick of 2010219 has failed:

On branch mergify/bp/2.6.x/pr-671
Your branch is up to date with 'origin/2.6.x'.

You are currently cherry-picking commit 2010219.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   code/XMLTester.xml
	modified:   docs/fastdds/transport/tcp/tcp.rst
	modified:   docs/fastdds/troubleshooting/troubleshooting.rst
	modified:   docs/fastdds/use_cases/large_data/large_data.rst
	modified:   docs/fastdds/use_cases/tcp/tcp_with_multicast_discovery.rst

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   docs/fastdds/rtps_layer/rtps_layer.rst

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@cferreiragonz cferreiragonz added this to the v2.6.8 milestone Mar 1, 2024
Signed-off-by: cferreiragonz <[email protected]>
@cferreiragonz
Copy link
Contributor

@richiprosima please test docs

@JesusPoderoso JesusPoderoso merged commit 791aab4 into 2.6.x Mar 4, 2024
4 checks passed
@JesusPoderoso JesusPoderoso deleted the mergify/bp/2.6.x/pr-671 branch March 4, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants