Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix windows warning with an union with boolean discriminator [20975] #339

Merged
merged 2 commits into from
May 9, 2024
Merged

Fix windows warning with an union with boolean discriminator [20975] #339

merged 2 commits into from
May 9, 2024

Conversation

richiware
Copy link
Member

@richiware
Refs 20973. Fix windows warning
cf61200 
Signed-off-by: Ricardo González Moreno <[email protected]>
@richiware richiware changed the title Fix windows warning with an union with boolean discriminator Fix windows warning with an union with boolean discriminator [20975] May 8, 2024
@richiware
Refs 20973. Update submodule
3e0e6d5 
Signed-off-by: Ricardo González Moreno <[email protected]>
adriancampo
adriancampo approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@adriancampo adriancampo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adriancampo adriancampo merged commit 0bafbd7 into 4.0.x-devel May 9, 2024
3 of 4 checks passed
@adriancampo adriancampo deleted the bugfix/20973 branch May 9, 2024 12:24
EduPonz pushed a commit that referenced this pull request May 14, 2024
@richiware @EduPonz
Fix windows warning with an union with boolean discriminator [20975] (#…
25cfc90 
…339)

* Refs 20973. Fix windows warning

Signed-off-by: Ricardo González Moreno <[email protected]>

* Refs 20973. Update submodule

Signed-off-by: Ricardo González Moreno <[email protected]>

---------

Signed-off-by: Ricardo González Moreno <[email protected]>
EduPonz pushed a commit that referenced this pull request May 16, 2024
@richiware @EduPonz
Fix windows warning with an union with boolean discriminator [20975] (#…
2af62db 
…339)

* Refs 20973. Fix windows warning

Signed-off-by: Ricardo González Moreno <[email protected]>

* Refs 20973. Update submodule

Signed-off-by: Ricardo González Moreno <[email protected]>

---------

Signed-off-by: Ricardo González Moreno <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adriancampo adriancampo adriancampo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@richiware @adriancampo