Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[21575] Fix map first arg typename #294

Merged
merged 2 commits into from
Sep 5, 2024
Merged

[21575] Fix map first arg typename #294

merged 2 commits into from
Sep 5, 2024

Conversation

haarisr
Copy link
Contributor

@haarisr haarisr commented Feb 2, 2024

closes #288

@haarisr haarisr closed this Feb 14, 2024
@haarisr haarisr reopened this Feb 14, 2024
@haarisr
Copy link
Contributor Author

haarisr commented Feb 15, 2024 •
edited
Loading

@JLBuenoLopez-eProsima @Mario-DL bumping this

@EduPonz EduPonz added this to the v3.3.0 milestone Feb 15, 2024
@EduPonz
Copy link

EduPonz commented Feb 15, 2024

Hi @haarisr, thanks for your contribution!

We are not sure whether this PR addresses the problem in its entirety, we will try to extended in the upcoming week and include the fix in v3.3.0

@JesusPoderoso
Copy link
Contributor

Hi @haarisr thanks for your contribution.

We are not sure whether this PR addresses the problem in its entirety, we will try to extended in the upcoming week and include the fix in v3.3.0

Unfortunately, we didn't make it, so we are not able to include the fix for v3.3.0. I moving it to v4.0.0 milestone for now.

@JesusPoderoso JesusPoderoso modified the milestones: v3.3.0, v4.0.0 Feb 22, 2024
@rsanchez15 rsanchez15 modified the milestones: v4.0.0, v4.0.1 Jul 26, 2024
@haarisr
Copy link
Contributor Author

haarisr commented Sep 4, 2024

Hi,

Is there an update on this? I would like to update my version of fast dds but this is still a blocker for me.

@Mario-DL
Copy link
Member

Mario-DL commented Sep 5, 2024

Hi @haarisr,

Sorry for the inconvenience. We will evaluate it soon and see if we can include it in the next release.

@Mario-DL Mario-DL changed the title Fix map first arg typename [21575] Fix map first arg typename Sep 5, 2024
Mario-DL
Mario-DL approved these changes Sep 5, 2024
View reviewed changes
Copy link
Member

@Mario-DL Mario-DL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in local, LGTM

@MiguelCompany MiguelCompany merged commit 8cba9fc into eProsima:master Sep 5, 2024
2 of 4 checks passed
@MiguelCompany
Copy link
Member

@Mergifyio backport 3.3.x

@mergify Mergify
Copy link

mergify bot commented Sep 5, 2024 •
edited
Loading

backport 3.3.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Sep 5, 2024
@haarisr @mergify
Fix python generation for maps (#294)
54fc6b2 
* Fix map first arg typename

Signed-off-by: haaris <[email protected]>

* No scoped name for custom type as values

Signed-off-by: haaris <[email protected]>

---------

Signed-off-by: haaris <[email protected]>
(cherry picked from commit 8cba9fc)
@mergify mergify bot mentioned this pull request Sep 5, 2024
Merged
MiguelCompany pushed a commit that referenced this pull request Sep 10, 2024
@mergify @haarisr
Fix python generation for maps (#294) (#392)
78fe3e2 
* Fix map first arg typename

Signed-off-by: haaris <[email protected]>

* No scoped name for custom type as values

Signed-off-by: haaris <[email protected]>

---------

Signed-off-by: haaris <[email protected]>
(cherry picked from commit 8cba9fc)

Co-authored-by: haarisr <[email protected]>
@Mario-DL Mario-DL mentioned this pull request Sep 16, 2024
Merged
7 tasks
This was referenced Sep 18, 2024
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mario-DL Mario-DL Mario-DL approved these changes

@richiprosima richiprosima Awaiting requested review from richiprosima

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v4.0.1
Development

Successfully merging this pull request may close these issues.

Cannot generate python bindings for map data type
6 participants
@haarisr @EduPonz @JesusPoderoso @Mario-DL @MiguelCompany @rsanchez15