Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the type object with its full scoped name #160

Closed
wants to merge 1 commit into from

Conversation

jihot2000
Copy link

When adding a type object, only the type name is added. Its scope is omitted. That may result in a conflict between two types with the same name but in different scopes. For example, mod1::structA and mod2::structA

module mod1 { struct structA {...}; };
module mod2 { struct structA {...}; };

@JLBuenoLopez JLBuenoLopez added this to the v2.5.0 milestone Jun 6, 2023
@MiguelCompany MiguelCompany modified the milestones: v2.5.0, v2.5.1 Jun 12, 2023
@EduPonz EduPonz modified the milestones: v2.5.1, v2.5.2 Jun 23, 2023
@AndreaFinazzi
Copy link

Could this issue eProsima/Fast-DDS#3296 (comment) be related?

@EduPonz
Copy link

EduPonz commented Feb 15, 2024

This should have been addressed in this branch, which will be part of the next major release in upcoming months. Thanks!

@EduPonz EduPonz closed this Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants