Apply the feedback #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meiertgrootes
approved these changes
Jan 9, 2022
There was a problem hiding this comment.
Thanks @rogerkuou looks great. Go ahead and merge a far as I'm concerned.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Meiert, I have addressed your comments on this:
#4: there are now two examples of retiling. One with default setting and one using grid-cell. Differences between these two are addressed.
#5 and #6: Indeed as Francesco said this caused by the boundary being smaller than actual dataset. This is fixed and the recommended boundary setting is addressed.
#7: I visualized the entropy height and point density geotiff.