Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(progress-stepper): updated upcoming color to meet contrast #2513

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

saiponnada
Copy link
Contributor

@saiponnada saiponnada commented Dec 18, 2024

Fixes #2494

  • This PR contains CSS changes
  • This PR does not contain CSS changes

Description

  • Updated the icon color to --color-stroke-default from --color-background-disabled in icons.svg file for icon-stepper-upcoming-24 to meet contrast.

Screenshots

Before
image

After
image

Checklist

  • I verify the build is in a non-broken state
  • I verify all changes are within scope of the linked issue
  • I regenerated all CSS files under dist folder
  • I tested the UI in all supported browsers
  • I did a visual regression check of the components impacted by doing a Percy build and approved the build
  • I tested the UI in dark mode and RTL mode
  • I added/updated/removed Storybook coverage as appropriate

Copy link

changeset-bot bot commented Dec 18, 2024

🦋 Changeset detected

Latest commit: 39cff68

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ebay/skin Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@saiponnada saiponnada self-assigned this Dec 18, 2024
Copy link
Contributor

@agliga agliga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to change stepper upcoming icon as well

@saiponnada saiponnada requested a review from agliga December 19, 2024 19:06
@saiponnada saiponnada merged commit 2e43568 into 18.6.0 Dec 19, 2024
@saiponnada saiponnada deleted the stepper-fix branch December 19, 2024 22:00
This was referenced Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants