Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eek): added large styles #2480

Merged
merged 2 commits into from
Nov 6, 2024
Merged

feat(eek): added large styles #2480

merged 2 commits into from
Nov 6, 2024

Conversation

agliga
Copy link
Contributor

@agliga agliga commented Nov 1, 2024

Fixes #2469

  • This PR contains CSS changes
  • This PR does not contain CSS changes

Description

  • Added large eek size
  • As part of this, I noticed the eek arrow was too small, fixed it to be larger
  • There were no stories, so I added those as well.
  • After adding storeis, I saw there were some RTL issues. Fixed RTL issues as well.
  • note there is an open question to design about the regular EEK size but that can be done in a followup. The main issue is the height of the range portion is 20px, but the text range is supposed to be 8px and the icon is 6px. So 8+8+6 = 22px which is too large. But this isn't a problem in large EEK.

Screenshots

Screenshot 2024-11-01 at 9 08 34 AM

Checklist

  • I verify the build is in a non-broken state

  • I verify all changes are within scope of the linked issue

  • I regenerated all CSS files under dist folder

  • I tested the UI in all supported browsers

  • I did a visual regression check of the components impacted by doing a Percy build and approved the build

  • I tested the UI in dark mode and RTL mode

  • I added/updated/removed Storybook coverage as appropriate

@agliga agliga self-assigned this Nov 1, 2024
Copy link

changeset-bot bot commented Nov 1, 2024

🦋 Changeset detected

Latest commit: a2a7898

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ebay/skin Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@ArtBlue ArtBlue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall; just a couple of minor things.

Copy link
Contributor

@ArtBlue ArtBlue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@agliga agliga merged commit 207c518 into 18.5.0 Nov 6, 2024
@agliga agliga deleted the eek-large branch November 6, 2024 20:05
@github-actions github-actions bot mentioned this pull request Nov 6, 2024
@github-actions github-actions bot mentioned this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants