Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(textbox): add blue focus indicator #2105

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

ArtBlue
Copy link
Contributor

@ArtBlue ArtBlue commented Jul 31, 2023

Fixes #2089

  • This PR contains CSS changes
  • This PR does not contain CSS changes

Description

Added blue focus indicator to improve UX and a11y as well as focus consistency across controls.

Screenshots

Before:
image

After:
image

Checklist

  • I verify the build is in a non-broken state
  • I verify all changes are within scope of the linked issue
  • I regenerated all CSS files under dist folder
  • I tested the UI in all supported browsers
  • I did a visual regression check of the components impacted by doing a Percy build and approved the build
  • I tested the UI in dark mode and RTL mode
  • I added/updated/removed Storybook coverage as appropriate

@ArtBlue ArtBlue self-assigned this Jul 31, 2023
@ArtBlue ArtBlue requested review from agliga and LuLaValva July 31, 2023 16:32
Copy link
Member

@LuLaValva LuLaValva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, as long as this is what we want by design. Approved!

I don't see outlines on Figma, so if we're truly looking for consistency across form elements maybe we should add an outline-offest to stay consistent with the switch:
image

@ArtBlue
Copy link
Contributor Author

ArtBlue commented Aug 1, 2023

Looks good, as long as this is what we want by design. Approved!

I don't see outlines on Figma, so if we're truly looking for consistency across form elements maybe we should add an outline-offest to stay consistent with the switch: image

@LuLaValva , I agree with you in theory. I've brought that up in the past and recall being told that switch is an exception. I think since it is such a compact component and it already has such a heavy stroke, it needs to have a bit of an offset to make the focus state indicator super clear.

Since input is more like combobox and select, it makes sense that it be consistent with those components rather than switch.

@ArtBlue ArtBlue merged commit 26ba2bc into 16.6.0 Aug 1, 2023
@ArtBlue ArtBlue deleted the 2089-textbox-add-blue-focus-indicator branch August 1, 2023 20:53
agliga pushed a commit that referenced this pull request Aug 4, 2023
@agliga agliga mentioned this pull request Nov 13, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants