Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(segmented-button): fixed non-current buttons on dark mode #2097

Merged
merged 1 commit into from
Jul 13, 2023
Merged

fix(segmented-button): fixed non-current buttons on dark mode #2097

merged 1 commit into from
Jul 13, 2023

Conversation

ArtBlue
Copy link
Contributor

@ArtBlue ArtBlue commented Jul 13, 2023 •
edited
Loading

Fixes #2096

  • This PR contains CSS changes
  • This PR does not contain CSS changes

Description

Fixed segmented button non-current button colors on dark mode.

Screenshots

Before:
image

After:
image

Checklist

  • I verify the build is in a non-broken state
  • I verify all changes are within scope of the linked issue
  • I regenerated all CSS files under dist folder
  • I tested the UI in all supported browsers
  • I did a visual regression check of the components impacted by doing a Percy build and approved the build
  • I tested the UI in dark mode and RTL mode
  • I added/updated/removed Storybook coverage as appropriate

@ArtBlue ArtBlue self-assigned this Jul 13, 2023
@ArtBlue ArtBlue requested review from agliga and LuLaValva July 13, 2023 18:13
LuLaValva
LuLaValva approved these changes Jul 13, 2023
View reviewed changes
Copy link
Member

@LuLaValva LuLaValva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks @ArtBlue

@ArtBlue ArtBlue merged commit 619131c into 16.5.0 Jul 13, 2023
@ArtBlue ArtBlue deleted the 2096-segmented-button-dark-buttons-invisible branch July 13, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agliga agliga agliga approved these changes

@LuLaValva LuLaValva LuLaValva approved these changes

Assignees

@ArtBlue ArtBlue

Labels
module: segmented-buttons type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ArtBlue @agliga @LuLaValva