Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(button): added small height #2071

Merged
merged 1 commit into from
May 25, 2023
Merged

feat(button): added small height #2071

merged 1 commit into from
May 25, 2023

Conversation

agliga
Copy link
Contributor

@agliga agliga commented May 24, 2023

Fixes #2066

  • This PR contains CSS changes
  • This PR does not contain CSS changes

Description

  • Added small height modifier to button

Notes

  • Added some new stories for testing
  • We had an old variable small already in the code (it was being used for regular). I deprecated that, added a regular size and a small-new size (we can rename it, but its only used in interim until next major.

Screenshots

Screen Shot 2023-05-24 at 8 35 26 AM

Checklist

  • I verify the build is in a non-broken state
  • I verify all changes are within scope of the linked issue
  • I regenerated all CSS files under dist folder
  • I tested the UI in all supported browsers
  • I did a visual regression check of the components impacted by doing a Percy build and approved the build
  • I tested the UI in dark mode and RTL mode
  • I added/updated/removed Storybook coverage as appropriate

@agliga agliga self-assigned this May 24, 2023
Copy link
Member

@LuLaValva LuLaValva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't add these as directed comments because they are in different files, but you skipped cta-button and segmented-buttons in your refactor from @button-height-small to @button-height-small-new. You should be able to find all instances with a project-wide search.

Otherwise, looks great! Just a small concern with the less variable name.

@agliga agliga changed the base branch from master to 16.3.0 May 25, 2023 17:15
@agliga
Copy link
Contributor Author

agliga commented May 25, 2023

I can't add these as directed comments because they are in different files, but you skipped cta-button and segmented-buttons in your refactor from @button-height-small to @button-height-small-new. You should be able to find all instances with a project-wide search.

Otherwise, looks great! Just a small concern with the less variable name.

I am doing to do segmented buttons as part of another PR since the large style depends on this change. I can update cta button.

Copy link
Member

@LuLaValva LuLaValva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for making the changes.

@agliga
Copy link
Contributor Author

agliga commented May 25, 2023

I'm going to merge this. If there are any other changes I can do it as a follow up. This is needed for the segmented-button changes

@agliga agliga merged commit aaf9bb5 into 16.3.0 May 25, 2023
@agliga agliga deleted the button-height branch May 25, 2023 17:28
ArtBlue pushed a commit that referenced this pull request Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

button: add small height
2 participants