Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added dialog, menu/listbox dropdowns, and toast rounded corners #1266

Merged
merged 6 commits into from
Oct 16, 2020

Conversation

agliga
Copy link
Contributor

@agliga agliga commented Oct 14, 2020

Description

  • Added rounding to dialog
  • Added rounding to menu/listbox overlays
  • Added toast rounded corners

Context

There is an issue with @media queries in the properties file.
Basically all media queries are hoisted to the previous media query. If put in the properties, the media query gets loaded in the previous one (which is section notice). This makes it so that it doesn't take prescedence. I had to put it AFTER loading the base file in order to get it to work. This is only for toast which has rounded bottom corners on dweb and no rounded bottom corners on mweb.

References

#1254

Screenshots

Screen Shot 2020-10-14 at 11 49 35 AM

Screen Shot 2020-10-14 at 11 49 45 AM

Screen Shot 2020-10-14 at 11 49 03 AM

Screen Shot 2020-10-14 at 11 49 09 AM

Screen Shot 2020-10-14 at 11 49 26 AM

@agliga agliga requested a review from ianmcburnie October 14, 2020 18:52
@agliga agliga self-assigned this Oct 14, 2020
Copy link
Contributor

@ianmcburnie ianmcburnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The listbox and menu buttons look a little off with rounded corners. We can either wait and cleanup when we get the go ahead to move this out of experiment status, or add some specific rules behind the .skin-experiment-rounded flag now.

Screen Shot 2020-10-14 at 12 38 49 PM

Screen Shot 2020-10-14 at 12 44 09 PM

@agliga agliga merged commit f532eec into 11.1.0 Oct 16, 2020
@ianmcburnie ianmcburnie deleted the overlay-rounding branch November 6, 2020 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants