Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dropdown list button to include inline label #1504

Closed
randybascue opened this issue Jul 8, 2021 · 3 comments
Closed

Update dropdown list button to include inline label #1504

randybascue opened this issue Jul 8, 2021 · 3 comments
Assignees
@ianmcburnie
Labels
module: listbox-button module: menu-button resolution: done
Milestone
13.0.0

Comments

@randybascue
Copy link

randybascue commented Jul 8, 2021 •
edited
Loading

We are updating the dropdown button to provide a label within the container.

Figma reference

Delta

Variants

Mobile

Desktop
@ianmcburnie
Copy link
Contributor

One step ahead of you :-) But I guess we can make this the defacto/default now. Cheers!

Screen Shot 2021-07-08 at 3 00 34 PM

@randybascue
Copy link
Author

Excellent! Sounds like this can be closed then.

@ianmcburnie ianmcburnie self-assigned this Jul 13, 2021
ianmcburnie added a commit that referenced this issue Aug 7, 2021
@ianmcburnie
docs: update labelling guidance #1504
f047d07
@ianmcburnie ianmcburnie mentioned this issue Aug 7, 2021
Merged
@ianmcburnie ianmcburnie added this to the 13.0.0 milestone Aug 7, 2021
@ianmcburnie
Copy link
Contributor

Merged to 13.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ianmcburnie ianmcburnie

Labels
module: listbox-button module: menu-button resolution: done
Projects
None yet
Milestone
13.0.0
Development

No branches or pull requests
2 participants
@ianmcburnie @randybascue