Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pagination: design system updates Part 1 of 3 (EVO) #1435

Closed
randybascue opened this issue May 11, 2021 · 3 comments
Closed

pagination: design system updates Part 1 of 3 (EVO) #1435

randybascue opened this issue May 11, 2021 · 3 comments

Comments

@randybascue
Copy link

randybascue commented May 11, 2021

Pagination will be simplified to use styling similar to new tabs. The controls will use the new icon button styling. Overflow variants account for pages between the first set and the last page. First and last page will always be visible.

Part 1 (this ticket) updates the styles only. Part 2 (#1519) adds the overflow interaction and new states.

Documentation

Desktop example
Delta
Specs
Variants

@agliga
Copy link
Contributor

agliga commented May 12, 2021

Looks great!
One question, what about the case where we have pages 1 thru 80 and the user is on page 50 lets say. What does it look like with the dots? Do we show: 1 ... 50 ... 80?

@randybascue
Copy link
Author

Took a more thorough pass regarding the rules around overflow. Feel free to review the Figma file for better detail. And let me know if you have any questions about the proposed logic.

Delta
Specs
Variants
Desktop example

@ianmcburnie ianmcburnie added this to the 13.0.0 milestone Jun 8, 2021
@ianmcburnie ianmcburnie changed the title Update pagination component pagination: design system updates (EVO) Jun 28, 2021
@ianmcburnie ianmcburnie changed the title pagination: design system updates (EVO) pagination: design system updates Part 1 of 2 (EVO) Jul 21, 2021
@ianmcburnie
Copy link
Contributor

First part is done in 13.0.0 branch. Closing.

@ianmcburnie ianmcburnie changed the title pagination: design system updates Part 1 of 2 (EVO) pagination: design system updates Part 1 of 3 (EVO) Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants