Add timeout for snapshot_sync_ctx #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaoxichen
reviewed
Jan 13, 2025
xiaoxichen
reviewed
Jan 13, 2025
greensky00
reviewed
Jan 13, 2025
include/libnuraft/raft_params.hxx
Outdated
| @@ -74,6 +74,7 @@ struct raft_params { | |||
| , log_sync_stop_gap_(99999) | |||
| , snapshot_distance_(0) | |||
| , snapshot_block_size_(0) | |||
| , snapshot_sync_ctx_timeout_(2500) | |||
There was a problem hiding this comment.
Put 0 by default, and if zero, keep the current behavior (heart_beat_interval_ * response_limit_). There are lots of users with different heartbeats, and such a newly introduced parameter with a fixed default value will suddenly break their systems.
There was a problem hiding this comment.
Sure, good suggestion, thx.
greensky00
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a dedicated timeout for snapshot_sync_ctx, and user can set this value in raft_param.