Fix DBConfig used in builder #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 4, 2024 12:20
greensky00
reviewed
Oct 8, 2024
include/libjungle/jungle_builder.h
Outdated
| /** | ||
| * DBConfig for the DB instance to be created. | ||
| */ | ||
| const DBConfig* dbConfig; |
There was a problem hiding this comment.
It should be DBConfig dbConfig, not pointer. The caller (of init) life span may not be longer than builder's life span.
There was a problem hiding this comment.
In the init() function, https://github.com/eBay/Jungle/pull/177/files#diff-e81fa7970a0833b1cb0b4bdbfadfefa84eaee52400bbf5d0b49d47bbe5474e63R121-R124
We already copy the passed in db_config to the dbConfig member of Builder, the pointer in this BuildParams will have the same life span as Builder.
greensky00
approved these changes
Oct 8, 2024
include/libjungle/jungle_builder.h
Outdated
| /** | ||
| * DBConfig for the DB instance to be created. | ||
| */ | ||
| const DBConfig* dbConfig; |
greensky00
requested changes
Oct 8, 2024
I change it from pointer to regular object so that BuilderParams will have a default db config. |
greensky00
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.