-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract get_hs_pg() function for simplicity #257
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #257 +/- ##
==========================================
- Coverage 63.15% 62.33% -0.83%
==========================================
Files 32 33 +1
Lines 1900 2546 +646
Branches 204 307 +103
==========================================
+ Hits 1200 1587 +387
- Misses 600 795 +195
- Partials 100 164 +64 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
RELEASE_ASSERT(iter != _pg_map.end(), "PG not found"); | ||
hs_pg = dynamic_cast< HS_PG* >(iter->second.get()); | ||
} | ||
auto hs_pg = get_hs_pg(pg_id); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RELEASE_ASSERT(hs_pg != nullptr, "pg not found")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, fixed & double-checked.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Extract
get_hs_pg()/_get_hs_pg_unlock()
functions for simplicity.