-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add trafo/shunt characteristics and phase shifter logics #2490
base: develop
Are you sure you want to change the base?
add trafo/shunt characteristics and phase shifter logics #2490
Conversation
panos-xenos
commented
Dec 12, 2024
•
edited
Loading
edited
- CGMES2pp converter: add trafo_characteristic_table & shunt__characteristic_table; amend trafo spline characteristic logic to use characteristic table; introduce shunt spline characteristics; amend/rename/introduce trafo/trafo3w/shunt parameters to reflect changes.
- Phase shifters: introduce different types of phase shifters for trafo and trafo3w; amend build_branch & build_bus to reflect all changes.
- Pytests: amend/introduce pytests & corresponding libs/test network files to reflect changes above.
…ts for voltage_ratio & angle_deg
…s into the converter; move trafo & shunt spline characteristic creation out of the converter (old code commented)
…dex with id_characteristic_table; remove individual spline characteristic indices from trafo and shunt tables; create one row per trafo/shunt in trafo_characteristic_spline & shunt_characteristic_spline tables with all spline characteristic objects
…teristic_table to step_dependency_table
…p_step_degree with the values corresponding to the neutral tap position for PhaseTapChangerTabular trafos
# Conflicts: # pandapower/test/api/test_auxiliary.py
…st:5: WARNING: Inline strong start-string without end-string.
This reverts commit d87a32e.
@pawellytaev @vogt31337, I see that one pipeline (Spinx docs check) is now failing but not sure why. Tried to debug but cannot run it locally and the log messages are not clear. Can you please have a look? EDIT: @JakobKirschner helped me find the solution to this sphinx issue - this had to do with the latest commit to the develop branch last week. This is no longer a failed pipeline. |
…terminal_id in net.measurement
@mrifraunhofer please note and review the last commit - we picked up a bug in net.measurement where we ended up with multiple nan rows at the end. I also added extracting one more column in net.measurement (terminal_id) because this is needed for state estimation. Please confirm you are happy - thx |
FYI, this is now complete/merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good in general, please address the conversations, then I will also approve :)
thanks for the PR and the extensions!
@pawellytaev all your comments are now addressed. Please confirm you are happy and approve! 💯 EDIT: @pawellytaev, I realized that some pipelines were failing again so I committed a few more changes:
Can you please help to resolve this? |