Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add trafo/shunt characteristics and phase shifter logics #2490

Open
wants to merge 200 commits into
base: develop
Choose a base branch
from

Conversation

panos-xenos
Copy link

@panos-xenos panos-xenos commented Dec 12, 2024

  • CGMES2pp converter: add trafo_characteristic_table & shunt__characteristic_table; amend trafo spline characteristic logic to use characteristic table; introduce shunt spline characteristics; amend/rename/introduce trafo/trafo3w/shunt parameters to reflect changes.
  • Phase shifters: introduce different types of phase shifters for trafo and trafo3w; amend build_branch & build_bus to reflect all changes.
  • Pytests: amend/introduce pytests & corresponding libs/test network files to reflect changes above.

panos-xenos and others added 30 commits October 9, 2024 18:39
…s into the converter; move trafo & shunt spline characteristic creation out of the converter (old code commented)
…dex with id_characteristic_table; remove individual spline characteristic indices from trafo and shunt tables; create one row per trafo/shunt in trafo_characteristic_spline & shunt_characteristic_spline tables with all spline characteristic objects
…p_step_degree with the values corresponding to the neutral tap position for PhaseTapChangerTabular trafos
# Conflicts:
#	pandapower/test/api/test_auxiliary.py
@panos-xenos
Copy link
Author

panos-xenos commented Feb 3, 2025

@pawellytaev @vogt31337, I see that one pipeline (Spinx docs check) is now failing but not sure why. Tried to debug but cannot run it locally and the log messages are not clear. Can you please have a look?

EDIT: @JakobKirschner helped me find the solution to this sphinx issue - this had to do with the latest commit to the develop branch last week. This is no longer a failed pipeline.

@heckstrahler heckstrahler removed their request for review February 4, 2025 12:56
@panos-xenos
Copy link
Author

@mrifraunhofer please note and review the last commit - we picked up a bug in net.measurement where we ended up with multiple nan rows at the end. I also added extracting one more column in net.measurement (terminal_id) because this is needed for state estimation. Please confirm you are happy - thx

@panos-xenos
Copy link
Author

Important note: This PR is dependent on lightsim2grid PR99 to ensure we get no load flow errors due to the parameter name change from tap_phase_shifter to tap_changer_type.

FYI, this is now complete/merged.

mrifraunhofer
mrifraunhofer previously approved these changes Feb 6, 2025
pandapower/build_bus.py Outdated Show resolved Hide resolved
Copy link
Contributor

@pawellytaev pawellytaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good in general, please address the conversations, then I will also approve :)
thanks for the PR and the extensions!

@panos-xenos
Copy link
Author

panos-xenos commented Feb 7, 2025

@pawellytaev all your comments are now addressed. Please confirm you are happy and approve! 💯

EDIT: @pawellytaev, I realized that some pipelines were failing again so I committed a few more changes:

  • update pyproject.toml to the latest lightsim2grid version
  • there was a todo and a pytest in test_contingency.py which were supposed to be removed once lightsim2grid version >0.10.0 is released. I made the suggested changes in that lib but now I'm getting some pytest error for case118.

Can you please help to resolve this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants