Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated projection keyword in simple_plotly #2469

Merged
merged 11 commits into from
Dec 19, 2024

Conversation

KS-HTK
Copy link
Collaborator

@KS-HTK KS-HTK commented Nov 29, 2024

While reviewing Issues/1785 I discovered some deprecated and some complicated code.

Added deprecations for the projection keyword as geojson is always WGS84.

See PR #2470 for the removal of the deprecation.

Copy link

codecov bot commented Nov 29, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 10 lines in your changes missing coverage. Please review.

Project coverage is 76.12%. Comparing base (8e94af3) to head (ab151f1).
Report is 12 commits behind head on develop.

Files with missing lines Patch % Lines
pandapower/plotting/plotly/mapbox_plot.py 28.57% 5 Missing ⚠️
pandapower/plotting/plotly/simple_plotly.py 85.18% 4 Missing ⚠️
pandapower/plotting/plotly/traces.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2469   +/-   ##
========================================
  Coverage    76.12%   76.12%           
========================================
  Files          284      284           
  Lines        33334    33343    +9     
========================================
+ Hits         25376    25383    +7     
- Misses        7958     7960    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KS-HTK KS-HTK requested a review from vogt31337 December 19, 2024 09:53
@vogt31337 vogt31337 merged commit a99f884 into e2nIEE:develop Dec 19, 2024
16 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants