Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues/2430 #2460

Merged
merged 7 commits into from
Dec 9, 2024
Merged

Issues/2430 #2460

merged 7 commits into from
Dec 9, 2024

Conversation

KS-HTK
Copy link
Collaborator

@KS-HTK KS-HTK commented Nov 25, 2024

closes #2430

@KS-HTK
updated for geojson support
27447aa
@KS-HTK
removed ga wrapper function for better code quality
d8486f6
@KS-HTK
fixed formatting issues
26dbbb0 
switched to f-strings instead of % notation
added some type hints and docstrings
@KS-HTK
rewrote calculation to remove redundant calls
ef62aa2 
renamed vars to small letters as per python naming convention
@KS-HTK KS-HTK requested a review from mfranz13 November 25, 2024 11:01
@codecov Codecov
Copy link

codecov bot commented Nov 25, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 18.62348% with 201 lines in your changes missing coverage. Please review.

Project coverage is 76.27%. Comparing base (ca1b8d1) to head (2be9be0).
Report is 8 commits behind head on develop.

Files with missing lines Patch % Lines
...ower/converter/powerfactory/pp_import_functions.py 7.18% 155 Missing ⚠️
pandapower/protection/utility_functions.py 42.50% 46 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2460      +/-   ##
===========================================
+ Coverage    76.04%   76.27%   +0.22%     
===========================================
  Files          282      282              
  Lines        33035    32944      -91     
===========================================
+ Hits         25123    25127       +4     
+ Misses        7912     7817      -95

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

KS-HTK and others added 2 commits November 26, 2024 11:35
@KS-HTK
fixed us of net.bus_geodata and net.line_geodata
ce45bd0 
reformatted file
simplified some functions
renamed some capitalized variables
@KS-HTK
Merge branch 'develop' into issues/2430
f97d482
@KS-HTK KS-HTK requested review from mrifraunhofer and removed request for mfranz13 November 27, 2024 07:42
@vogt31337 vogt31337 closed this Dec 9, 2024
@vogt31337 vogt31337 reopened this Dec 9, 2024
@vogt31337 vogt31337 merged commit 37db174 into e2nIEE:develop Dec 9, 2024
22 of 30 checks passed
@KS-HTK KS-HTK deleted the issues/2430 branch December 10, 2024 08:25
@KS-HTK KS-HTK mentioned this pull request Dec 12, 2024
Merged
vogt31337 added a commit that referenced this pull request Dec 13, 2024
@vogt31337
Merge pull request #2489 from KS-HTK/issues/fix-for-pr-2460
8f247bd 
Fixing issues from PR #2460
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vogt31337 vogt31337 vogt31337 approved these changes

@mrifraunhofer mrifraunhofer Awaiting requested review from mrifraunhofer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug] replace old net.bus_geodata, net.line_geodata by up-to-date net.bus.geo, net.line.geo
2 participants
@KS-HTK @vogt31337