Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding vectorgroup dynyn to 3w-transformer #2283

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

nis-bucr
Copy link

@nis-bucr nis-bucr commented May 7, 2024

Problem

The vectorgroup Dynyn was currently not supported for shortcircuit calculations of three winding transformers

Fix

Added the vectorgroup. Also fixed bug with vectorgroup Ynyy.

nis-bucr added 3 commits May 3, 2024 11:41
added Dynyn vectorgroup to 3wtrafo
fixed ynyy, minor changes in dynyn
@vogt31337
Copy link
Contributor

@nis-bucr thanks for this patch. Could you by any chance update the changelog?

Copy link

codecov bot commented Aug 7, 2024

Codecov Report

Attention: Patch coverage is 22.22222% with 7 lines in your changes missing coverage. Please review.

Project coverage is 76.45%. Comparing base (2698f7e) to head (dabe912).
Report is 114 commits behind head on develop.

Files with missing lines Patch % Lines
pandapower/pd2ppc_zero.py 22.22% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2283      +/-   ##
===========================================
- Coverage    76.47%   76.45%   -0.02%     
===========================================
  Files          281      281              
  Lines        32580    32587       +7     
===========================================
  Hits         24915    24915              
- Misses        7665     7672       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Added changelog for vecotrgroup addition
@nis-bucr
Copy link
Author

nis-bucr commented Aug 8, 2024

@vogt31337 Thank you for the review. I added the changelog message to upcoming release, hope this is correct.

@vogt31337
Copy link
Contributor

@nis-bucr thanks for updating. CodeCov reported that there is no test covering your changes/additions. Could you by any chance add a simple test for your dynyn 3w transformer?

added test for dynyn Vectorgroup
@nis-bucr
Copy link
Author

@vogt31337 I added a test to test_1ph.py for the dynyn vectorgroup. Could you please verify the values with your commercial calculating tool used for the other vectorgroups?

@vogt31337
Copy link
Contributor

@nis-bucr, thanks for updating!
@pawellytaev, could you verify this calculation with PF?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants