-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding vectorgroup dynyn to 3w-transformer #2283
base: develop
Are you sure you want to change the base?
Conversation
added Dynyn vectorgroup to 3wtrafo
fixed ynyy, minor changes in dynyn
fixed typos
@nis-bucr thanks for this patch. Could you by any chance update the changelog? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2283 +/- ##
===========================================
- Coverage 76.47% 76.45% -0.02%
===========================================
Files 281 281
Lines 32580 32587 +7
===========================================
Hits 24915 24915
- Misses 7665 7672 +7 ☔ View full report in Codecov by Sentry. |
Added changelog for vecotrgroup addition
@vogt31337 Thank you for the review. I added the changelog message to upcoming release, hope this is correct. |
@nis-bucr thanks for updating. CodeCov reported that there is no test covering your changes/additions. Could you by any chance add a simple test for your dynyn 3w transformer? |
added test for dynyn Vectorgroup
@vogt31337 I added a test to test_1ph.py for the dynyn vectorgroup. Could you please verify the values with your commercial calculating tool used for the other vectorgroups? |
@nis-bucr, thanks for updating! |
Problem
The vectorgroup Dynyn was currently not supported for shortcircuit calculations of three winding transformers
Fix
Added the vectorgroup. Also fixed bug with vectorgroup Ynyy.