-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
split toolbox.py and other improvements #1886
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
SteffenMeinecke
commented
Feb 24, 2023
•
edited
Loading
edited
- [CHANGED] split toolbox.py -> better overview, avoiding circular imports
- [ADDED] group consideration in toolbox replace element functionality
- [CHANGED] renamed functions: check_unique_group_names() -> check_unique_group_rows()
- [CHANGED] attach_to_group(): enable handling of different reference_column passed than existing
- [ADDED] toolbox function 'count_elements', 'drop_elements'
- [ADDED] new group functions 'element_associated_groups', 'attach_to_groups'
- [CHANGED] repr (used by print(net)) now considers groups appropriately
- [FIXED] get_equivalent()
- [CHANGED] aim for toolbox parameter name consistency: element_types, element_index (changes to mandatory parameters only)
…_group() -> attach_to_group()
* add _replace_group_member_element_type in toolbox functions
…/pandapower into rename_group_fct
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #1886 +/- ##
===========================================
+ Coverage 72.20% 72.33% +0.13%
===========================================
Files 197 202 +5
Lines 24439 24643 +204
===========================================
+ Hits 17646 17826 +180
- Misses 6793 6817 +24
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
…n in replacing ward and xwards
- enable handling of different reference_column in attach_to_group()
- improve __repr__
…ndex (changes to mandatory parameters only)
- changed element_bus_tuples()
ZhengLiu1119
approved these changes
Mar 6, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.