Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split toolbox.py and other improvements #1886

Merged
merged 48 commits into from
Mar 7, 2023

Conversation

SteffenMeinecke
Copy link
Member

@SteffenMeinecke SteffenMeinecke commented Feb 24, 2023

  • [CHANGED] split toolbox.py -> better overview, avoiding circular imports
  • [ADDED] group consideration in toolbox replace element functionality
  • [CHANGED] renamed functions: check_unique_group_names() -> check_unique_group_rows()
  • [CHANGED] attach_to_group(): enable handling of different reference_column passed than existing
  • [ADDED] toolbox function 'count_elements', 'drop_elements'
  • [ADDED] new group functions 'element_associated_groups', 'attach_to_groups'
  • [CHANGED] repr (used by print(net)) now considers groups appropriately
  • [FIXED] get_equivalent()
  • [CHANGED] aim for toolbox parameter name consistency: element_types, element_index (changes to mandatory parameters only)

@SteffenMeinecke SteffenMeinecke added the maintenance miscellaneous tasks for housekeeping and maintenance label Feb 24, 2023
@codecov
Copy link

codecov bot commented Feb 27, 2023

Codecov Report

Patch coverage: 88.17% and project coverage change: +0.13 🎉

Comparison is base (bca4efe) 72.20% compared to head (74084f9) 72.33%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1886      +/-   ##
===========================================
+ Coverage    72.20%   72.33%   +0.13%     
===========================================
  Files          197      202       +5     
  Lines        24439    24643     +204     
===========================================
+ Hits         17646    17826     +180     
- Misses        6793     6817      +24     
Impacted Files Coverage Δ
pandapower/grid_equivalents/toolbox.py 93.89% <ø> (ø)
pandapower/sql_io.py 22.96% <ø> (-0.74%) ⬇️
pandapower/converter/pandamodels/from_pm.py 54.16% <50.00%> (ø)
pandapower/converter/powerfactory/validate.py 15.80% <50.00%> (ø)
pandapower/auxiliary.py 85.62% <73.23%> (-1.50%) ⬇️
pandapower/groups.py 84.70% <80.41%> (+0.84%) ⬆️
pandapower/toolbox_general_issues.py 84.08% <84.08%> (ø)
pandapower/grid_equivalents/rei_generation.py 91.64% <84.61%> (-0.92%) ⬇️
pandapower/toolbox_elm_selection.py 84.82% <84.82%> (ø)
pandapower/toolbox_grid_modification.py 90.39% <90.39%> (ø)
... and 22 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@SteffenMeinecke SteffenMeinecke changed the title split toolbox.py and some other improvements split toolbox.py and other improvements Mar 1, 2023
@SteffenMeinecke SteffenMeinecke removed the request for review from rbolgaryn March 2, 2023 11:33
@SteffenMeinecke SteffenMeinecke merged commit 9a975c7 into e2nIEE:develop Mar 7, 2023
@SteffenMeinecke SteffenMeinecke mentioned this pull request Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance miscellaneous tasks for housekeeping and maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants