Multiple fixes to get conda setup working in more environments #741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My personal laptop had a version of conda even older than the docker container.
So old that it only supported `source activate` and not `conda activate`.
So we used `source activate` in the setup script and checked for the CI
variable before using it in `conda activate`.
This:
- supports `setup_conda` on multiple platforms
- upgrades all setup scripts to use `conda install`
- stops exiting from `check_for_conda` so it doesn't kill the shell
- updates the manual install test to also include osx, and to add osx to the
list of oses that we test against
- also pass in the platform correctly per OS so that the installation will
happen correctly
So we test install only ubuntu + osx and go back to linux only for install + tests This should also catch any inconsistencies between the dev setup and the test setup scripts (similar to e-mission/e-mission-docs#513 (comment))
Since it inexplicably fails on OSX + remove exit 1 since it is confusing in source scripts
- switch to conda on teardown as well - actually switch to the environment after installing it to ensure that it exists
So that there is more indication of what failed if something fails
jf87
pushed a commit
to jf87/e-mission-server
that referenced
this pull request
Jun 21, 2021
…sion#741) * Multiple fixes to get conda setup working in more environments My personal laptop had a version of conda even older than the docker container. So old that it only supported `source activate` and not `conda activate`. So we used `source activate` in the setup script and checked for the CI variable before using it in `conda activate`. This: - supports `setup_conda` on multiple platforms - upgrades all setup scripts to use `conda install` - stops exiting from `check_for_conda` so it doesn't kill the shell - updates the manual install test to also include osx, and to add osx to the list of oses that we test against - also pass in the platform correctly per OS so that the installation will happen correctly * Mongodb install action only works on ubuntu So we test install only ubuntu + osx and go back to linux only for install + tests This should also catch any inconsistencies between the dev setup and the test setup scripts (similar to e-mission/e-mission-docs#513 (comment)) * Remove miniconda check since osx doesn't have miniconda preinstalled * Add exit codes so we can see why this is failing * Checking to see if the error is with which conda * Check the conda path only on linux Since it inexplicably fails on OSX + remove exit 1 since it is confusing in source scripts * Final fixes - switch to conda on teardown as well - actually switch to the environment after installing it to ensure that it exists * Some more clarity into what we are doing So that there is more indication of what failed if something fails
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My personal laptop had a version of conda even older than the docker container.
So old that it only supported
source activateand notconda activate.So we used
source activatein the setup script and checked for the CIvariable before using it in
conda activate.This:
setup_condaon multiple platformsconda installcheck_for_condaso it doesn't kill the shelllist of oses that we test against
happen correctly