💅 Label Screen cleanup & polishing #998
Conversation
To avoid cluttering app.js more than necessary, I am extracting the logic to initialize i18next to a new file called i18nextInit.ts, which just performs the same initialization logic and exports the initialized instance of i18next. In tsconfig.json, `resolveJsonModule` was set `true` so that the JSON translation files can be imported in TypeScript.
and alias windowDimensions 'width' as 'windowWidth' for readability/clarity
|
The above commits are minor cleanups/improvements I already had, but didn't want to tack onto #993 while it was being reviewed. The most notable thing is that I implemented caching for the address names we fetch from OSM. I've always found it annoying that they're retrieved again on every app load. |
Note that we are also signing up for a paid subscription to geofabrik.de. Once that is done, we can fill in the addresses on the server. Regardless, we will still need direct client calls for draft trips, so this is a useful fix. Just might be less cool down the road. |
|
Sounds cool! I think this was still largely worthwhile because now we have a lightweight storage method to use instead of |
The `key` prop needs to go on the <View> here because that is the element being repeated; not the IconButton.
The filter state that is applied initially should be the first one in the list. This updates FilterSelect to reflect that.
JGreenlee
force-pushed
the
label-screen-migration-cleanup
branch
from
7a799fe to
7534f86
Compare
After converting the Label Screen UI to React components with #993, there are several items to address.
This PR will fix regressions, tidy, and continue to improve usability.