Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🏷️ Migration of Label Screen Components #993
🏷️ Migration of Label Screen Components #993
Changes from all commits
7bd2ad2
4ce4090
1aa1877
6578d8a
dbc896d
050b21d
a83e3cd
f105d83
395e600
b843160
613ea29
595b405
ac1d7e1
0349eeb
5b943f2
02e7a44
d71eb5f
4e8ec6e
91d8ea0
57d39c5
1d0871c
96506b5
9a4cba7
4bdd630
6cdcff0
9123f3f
960d134
7aee500
eaae2c3
3ae5406
93e73b9
9441ec5
a443365
43054a2
63bbaf1
b2bbd52
344936b
4a8db52
6fa9626
b657a28
cffed38
85838f4
606dfbd
c733b83
16ac7fb
fb9da34
910262a
aaae7c0
87a9f94
a3ebc3a
7027002
b306c7d
57342d7
84bf748
4c02c6b
fece489
f1faa0a
5c884d9
1736207
11fc98c
e96cdcd
fb6cceb
cb78608
7aff0d6
025bb8c
e2dd6f1
76756d5
77b1bdb
4242b1f
e52b751
3ee6263
aafe00f
2e9b315
8217a99
269f725
30146f0
1519b18
ee1d290
92063a3
8f56fdc
8eff214
89c119e
b9bff4d
dba6b23
e929f32
110267c
8c7d6e6
c350764
9551fd2
c0cf400
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
given that this is named
tsconfig.json
, will this only convert.tsx
files toes5
?until the conversion is done, we should really transpile all existing js files as well
I manually transpiled to fix e-mission/e-mission-docs#924
I guess I would be fine with not transpiling as long as we ensure that we have migrated the affected files in the issue above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point! I was thinking that everything would be transpiled at this point, but now that you point it out I do think it's just .ts and .tsx files.
I can't confirm at this moment that all affected files have been migrated. Let's definitely investigate that before a release.
If not, we can use webpack and babel to add yet another transpilation step, until everything that needs to be transpiled is written in TypeScript.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO later (try running a build on an old phone / outdated WebView)