🐛 💩 🚸 port fix, temporarily comment out error, make "fix" and "refresh" look like buttons #987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original fix: 1b2611a Before this, we had ``` $scope.ui_config.intro.app_required = $scope.ui_config?.intro.app_required || $scope.ui_config?.intro.program_or_study == 'program'; ``` This worked fine for backward compat, but in the case of a program where the app was not required, we ended up with `false || true` which is `true` Taking out the fancy javascript and going to a simpler, more verbose check of whether the property is undefined before overriding it
…results So that we don't confuse Denver CASR beta testers We will restore this later once we have moved to a paid service
Based on feedback from one of the interns > We got it working! I think the confusing part was that the "fix" and "refresh" buttons didn't really look like buttons and I missed them the first time around...
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 port over fix for the backwards compat code
🐛 💩 Temporarily comment out the error while retrieving the nominatim …
🚸 Make the "Fix" and "Refresh" buttons look like buttons