Update the documentation to remove dependency on android studio #818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an initial fix for e-mission/e-mission-docs#711 Additional fix is to automate some of the steps by including them in the setup and activate scripts.
- See if gradle is installed (prepartory to removing the manual install) - ensure that we use java 11 everywhere
This is in a separate scripts because: - it takes a long time - it only needs to be run once per computer Change readme to remove prior manual instructions and indicate that it is enough to run the prerequisite script Change activate to set the PATH variables correctly
Every time it changes, and every week to catch regressions
Update the documentation to remove dependency on android studio
* Comment out everything else and just echo the initial environment variables * Run the test CI for all pushes and PRs So that at least it shows up * Change the automated install to be identical to the CI workflow * Fix the file ending * Now introduce the actual changes we want to test * Fix the list_installed syntax * Enable all the other steps as well * actually run the install script Not sure why it is hanging through * Add some logging statements to check when the install is complete + ensure that this only runs when the prerequisite script is changed * Ensure that we explicitly exit from the script Since we are running it with `yes Y | ...` and it does not appear to exit automatically * Simplify the install script so we can see why it doesn't exit properly * Remove all prompts and make sure that it works * Remove the pipe to confirm that this the problem * Restore the prompts We will try different options to pass in the prompt since the `yes` pipe doesn't seem to work https://www.baeldung.com/linux/bash-interactive-prompts * Reintroduce the actual install now that the printf workaround seems to work * Fix install check and diff check - Diff check is expected to fail - Install check should be the last item so that the workflow will fail correctly * Add -x so we print lines before executing them Which makes it easier to find errors in these giant scripts * Fix syntax of single line command by adding appropriate semicolons ``` $ if [ ! -f $ANDROID_SDK_ROOT/emulator ]; then echo "not found" fi > -bash: syntax error: unexpected end of file $ if [ ! -f $ANDROID_SDK_ROOT/emulator ]; then echo "not found"; fi not found ``` * Fix the checks to look for directories and not files * Split the checks into two so we detect if either check fails * Restore the default CI to only run on the master branch Reverts "Run the test CI for all pushes and PRs" which will not be a separate commit once we squash and merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an initial fix for e-mission/e-mission-docs#711