Handle the case where no trips have been labeled for two weeks #806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is likely fairly common for those people who have given up on labeling, so it is worth addressing. The problem is that in that case, ``` lastWeek.footprint.low = 0 thisWeek.footprint.low = 0 thisWeek.footprint.low/lastWeek.footprint.low = NaN ``` So we end up with a blank "low" on the diff display, which looks weird. To fix, we add a pre-processing step to the directive, which converts NaN -> 0 and display the % if it is >= 0 This then leads to the marginally less weird case in which we don't show the arrow and we don't show the OR To fix that as well, we remove the `ng-if` for the OR (not sure why it was ever added) and add an = for the case in which the metric is 0
|
shankari
added a commit
to shankari/e-mission-phone
that referenced
this pull request
Jan 15, 2022
This is a merge of e-mission#806 and e-mission#806 into the currently deployed branch This primarily involved copying files over since the merge history has diverged significantly. Should really prioritize pushing out the status screen changes so that we don't have to do that in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is likely fairly common for those people who have given up on labeling, so
it is worth addressing. The problem is that in that case,
So we end up with a blank "low" on the diff display, which looks weird.
To fix, we add a pre-processing step to the directive, which converts NaN -> 0
and display the % if it is >= 0
This then leads to the marginally less weird case in which we don't show the
arrow and we don't show the OR
To fix that as well, we remove the
ng-iffor the OR (not sure why it was ever added)and add an = for the case in which the metric is 0