Add UI features and algorithm to support label inference #762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
GabrielKS
commented
Jun 28, 2021
GabrielKS
commented
- Phone now receives and processes label inference data structure from the server to determine what inferences to show the user
- Makes labels red if they have no value, yellow if they are inferred, and green if they are user input
- Adds a "verify" button that turns yellow labels green
+ Adds basic client-side processing of label inference data structure
- Minor restructuring of infinite_scroll_list.js to facilitate this
- Still need to write full client-side inference algorithm
+ Displays inferred labels in yellow and blank labels in red
+ Moves the "more" button on trip cards to the top right corner + Adds a verify button beneath it that turns yellow labels green + Fixes a bug that mis-positioned trip start and end icons if labels were blank + Like the previous commit, does not affect the Diary page
+ This algorithm takes the list of label tuples and probabilities from the server and chooses which yellow labels to show the user, taking into account what the user has already begun to enter. + Extensively documented in the comments. Testing done: Tested various cases using the more extensive server-side placeholder label inference "algorithm" recently committed.
|
@GabrielKS can you add some screenshots or animated gifs here to make it easier to review without pulling the changes and running them? |
shankari
approved these changes
Jun 29, 2021
| </div> | ||
| </div> | ||
| <div ng-click="verifyTrip($event, trip)" class="col-10 diary-checkmark-container center-vert center-horiz"> | ||
| <i ng-class="trip.verifiability" class="ion-checkmark-round"></i> |
There was a problem hiding this comment.
FYI, please continue using properties instead of functions here. Using functions to retrieve the ng-class, although it works, plays havoc with the caching and the performance really suffers.
|
Below is a GIF that showcases all of the changes implemented. The inference data is made up for instructional purposes. Here's what is happening for each trip:
|
|
Please submit the PR to fix the confirmation check for Trip 1 after I merge this. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.