Fix 'today' in the datepicker #668
Merged
+31
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This involved two fixes:
- recreating the config on resume so that the end date is reset (`list.js`), and
- setting "today" to the correct date when the datepicker is opened
(`ionic-datepicker.bundle.min.js`)
I have also added build instructions to my fork of the ionic-datepicker repo,
but in case I delete the fork later, the instructions are:
Install node 10.19.0 ([gulp-sass will fail for more recent version of node](nodejs/node-gyp#1763))
```
node -v
v10.19.0
```
Install and check gulp version
```
npm install
npm list | grep gulp
├─┬ [email protected]
```
Build
```
npx gulp build
```
Testing done:
Followed the steps in e-mission/e-mission-docs#531 (comment)
Both end date and today are updated correctly
|
@asiripanich can you please review this? I will then merge and deploy. Please test so that I can merge to master. |
|
sure! |
|
@asiripanich is that a review? |
|
@asiripanich by review, I mean look at the code. I already tested it (see the "testing done" in the commit). An external code review is almost always a good idea. |
|
Looks good to me. |
|
Could you please rebase and merge this pr? |
|
why do I need to rebase? It is already to rciti1... |
|
Ahh sorry my bad.. |
|
Tried the testing steps on my device and can report that the issue no longer exists. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This involved two fixes:
list.js), and(
ionic-datepicker.bundle.min.js)I have also added build instructions to my fork of the ionic-datepicker repo,
but in case I delete the fork later, the instructions are:
Install node 10.19.0 (gulp-sass will fail for more recent version of node)
Install and check gulp version
Build
Testing done:
Followed the steps in e-mission/e-mission-docs#531 (comment)
Both end date and today are updated correctly