-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import the setup scripts and the CI workflows for Github Actions #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by reusing the setup script for the CI
Essentially commit periodically until everything works -------------------------- * Fix the sign_and_align_keys script - Run cordova the new way - label the resulting apk correctly * Vastly simplify the instructions for installation by reusing the setup script for the CI * First version of the ios build * Let's see whether the ios build works * Actually switch to osx * Fixed name + case on macos runner * Switch back to ubuntu To see if this is launched now * Some more tries to get the ios build to work * Add another test To see if we can even launch two tests * Rename the working CI and see if it still works * Now change it to run on osx * Now change the line from an echo to sth meaningful * Now finally run sth related to xcode * Finally run the setup script + remove the malformed workflows * showbuildsettings only works in the ios directory which we don't have yet * Fix the xcodeselect + actually check in setup files * Fix the setup script + actually add ios and android builds * Fix infinite loop + remove android build * Fix plugin check + cordova launch * Specify a login shell * Refactor the setup scripts to be common v/s native * Upgrade cocoapods This no longer requires `pod setup` so is much faster and takes much less room * Let's also tear things down * Add in the teardown scripts as well * Don't have to remove cocoapods + minor fix to formatting * Lets try the gem uninstall without the piped y * Handle telemetry warnings better * Fixing this forever?! * Set the CI to true woo! woo! * Test out an initial android build Including some sense of the build environments * Run only on mac to avoid compile error + update README with android studio dependency * Try this on ubuntu * Try the android build * Add the actual build steps to the android workflow * Fix the ANDROID_HOME to use existing value * Remove the sdkmanager configurations since it looks like we can't modify them ``` setup/setup_android_native.sh: line 40: /usr/local/lib/android/sdk/tools/bin/sdkmanager: Permission denied ``` * More fixes * Remove the sdkmanager call since it doesn't work * Some more sdkman fixes * Make the setup changes "stick" * Last try to figure out how to use the proper gradle * Get cordova to actually fail on error + minor refactoring of common code * Upgrade node and npm versions This allows us to use the --unhandled-rejections CLI flag * Fix the sed script to work on the real file Instead of the symlinked location * Fail only for android for now * Let's put it back for iOS as well The previous failure seemed to be transient * More debugging for the gradle issue on android * Run android on os only as well Since: - the ubuntu build appears to be flaky - most app developers will build on mac in order to support ios as well
+ refactor the common elements out
To actually run the shared native code
+ ignore `.app.zip` files since that is how we generate iOS deliverables
This failure is expected since we haven't migrated over all the plugins yet. We will first migrate over the other changes and then fix the CI in a separate branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.