-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade the config.xml and plugins #636
Conversation
shankari
commented
Mar 30, 2020
- upgrade to API 28
- turn off google analytics
- upgrade to the latest version of the plugins
The related manifest change was already checked in thanks to @ericafenyo (e-mission#616)
Add android schema so that we can use `android:` tags in the xml + update ionic deploy to the `remove_swift_class` version
These were turned in by default when switching to Firebase This fixes e-mission/e-mission-docs#416
which fixes all current android build issues
At this point, the android build works
|
Will return to this to fix the iOS build tonight. |
So they are consistent with config.xml
Apple will not accept apps using anything other than WKWebView. According to the ionic docs, this requires
And yes, that is in fact required
which is needed because of There are apparently several limitations with WKWebView. Of the limitations they highlight,
We don't use cookies
We don't use cookies
Most of our functionality is already native code. But we do
We use XHR for the aggregate calls, need to fix them.
Fortunately, we moved away from local storage to the database a long time ago. Should probably remove alert about data missing from local storage.
No iframes
??? |
Given all the stuff that broke when we last tried to upgrade to cordova-ios@5, and the newer things that will break, I will migrate to the new system in the new app (https://github.com/covid19database/phone-app), which has fewer dependencies. Then, I can migrate the changes back here. |
To use the correct config file. This fixes e-mission/e-mission-docs#518
It turns out that I needed to upgrade not just the iOS version but also the android version in order to support kotlin. I will migrate all the changes over, but for now, I will merge these changes. |