Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label screen accessibility + custom labels + more profile migrations + upgrade to android 23 #1024

Merged
merged 174 commits into from
Sep 4, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
174 commits
Select commit Hold shift + click to select a range
2cab1ed
switched collect and sync lists over to react
Jun 13, 2023
ba5406e
inserted a placeholding div control-list-item
Jun 14, 2023
2ad296c
patch from Jack
Jun 14, 2023
dc1d661
Merge branch 'e-mission:framework_migration_prep' into framework_migr…
Abby-Wheelis Jun 15, 2023
89fadc7
added keys to rows
Jun 16, 2023
c40c9bb
removal of non-relevant code
Jun 16, 2023
af44bf0
replacing hard coded strings
Jun 16, 2023
f558103
start at storing data in better place
Jun 16, 2023
e8bb3d6
spelling
Jun 16, 2023
d8a12aa
starting to work with other rows of profile
Jun 16, 2023
5b20f9f
setting up issue in using key as parameter
Jun 16, 2023
0a629fa
fixing strings
Abby-Wheelis Jun 17, 2023
5db9dd8
text working on sample list item
Jun 20, 2023
337816c
carry data storage change through
Abby-Wheelis Jun 22, 2023
aa547f8
polishing up - removing print statements, altering log
Jun 22, 2023
11de879
update comments, eliminate changes not a part of this PR
Jun 22, 2023
399ea7a
Merge branch 'e-mission:master' into More-Profile-Migrations
Abby-Wheelis Jun 22, 2023
2ddfab5
action parameters for setting rows - some work
Jun 22, 2023
0e2a8f6
Merge branch 'framework_migration_prep' into More-Profile-Migrations
Jun 22, 2023
90eda2b
comments and spacing
Jun 22, 2023
f1373ec
more row migrations
Jun 22, 2023
10f571c
rough draft - two rows unconverted
Jun 23, 2023
0f239b0
fixing strings - i18n
Jun 23, 2023
8a5e546
enabling icons - copy Jack's related commit
Jun 23, 2023
ffab0df
got icons in
Jun 23, 2023
cad1034
tidy code - still ways to go
Jun 23, 2023
b6b1fc6
combine logout and copy (eliminate copy)
Jun 23, 2023
e8b7b19
convert to use of IconButtons
Jun 26, 2023
ebeca54
introduce toggle switches
Jun 26, 2023
813c4f5
experiment with list accordian
Jun 26, 2023
4553eb7
use of .map for creating the collapsing list!
Jun 26, 2023
2934b51
both drop-downs converted to ExpandMenu components
Jun 26, 2023
ddff054
profile settings component draft
Jun 27, 2023
803f782
profile settings in general settings
Jun 27, 2023
757936c
first set settings now in ProfileSettingsComponent
Jun 27, 2023
b4c70b3
different method of passing info to Profile Settings
Jun 27, 2023
df5da35
introduce Demographics Setting Row
Jun 27, 2023
a9043a2
rough sketch everything in ProfileSettings
Jun 28, 2023
e0f9983
more of migration to ProfileSettings component
Jun 28, 2023
7bc97b7
adding a value in the scope for the accuracy setting
Jun 28, 2023
f125321
Merge branch 'framework_migration_prep' into framework_migration_prep
Abby-Wheelis Jun 28, 2023
a3097ac
adding additional argument to angularize call
Jun 28, 2023
aa027ad
cleaned up irrelivant codes and comments
Jun 28, 2023
ffd2bc2
fixing merge conflicts
Jun 28, 2023
cf2871e
Merge pull request #1 from Abby-Wheelis/framework_migration_prep
Abby-Wheelis Jun 28, 2023
b612292
Revert "fixing merge conflicts"
Jun 28, 2023
51c0697
extra param in call to angularize func
Jun 28, 2023
60eb532
optional chaining with settings object
Jun 28, 2023
12f462c
styling for Setting Row
Jun 28, 2023
af58485
working with data flow - settings object
Jun 28, 2023
e106102
styling ExpandMenu
Jun 29, 2023
44bc1be
comment out old code
Jun 29, 2023
3eae605
work with the toggle
Jun 29, 2023
83443ed
begin general-settings to ProfileSettings move
Jun 29, 2023
ff4e490
made rows taller - more white space
Jun 29, 2023
2bf64d2
low accuracy toggle functions not working
Jun 29, 2023
20d29f4
make userData conditional
Jun 29, 2023
bfc6355
dialog menus - replacing action sheets
Jul 5, 2023
dfda0f1
migrating action sheets
Jul 5, 2023
ac73e43
action sheet migrations -- unresolved error
Jul 5, 2023
f2467fa
switched portal out for modal
Jul 6, 2023
f685472
address errors in accuracy toggle
Jul 6, 2023
532f56a
organizing code
Jul 6, 2023
7237343
make whole row clickable
Jul 6, 2023
ca4bd2d
migrate share method
Jul 6, 2023
e6ed67a
working on platform detection
Jul 6, 2023
eb3de5d
introduction of useEffect for keeping up with switches
Jul 6, 2023
3e1940b
Merge pull request #2 from e-mission/framework_migration_prep
Abby-Wheelis Jul 6, 2023
6e3562e
Merge branch 'framework_migration_prep' into More-Profile-Migrations
Jul 6, 2023
161a63c
Merge remote-tracking branch 'upstream/framework_migration_prep' into…
Jul 7, 2023
4a5f24a
Merge remote-tracking branch 'upstream/framework_migration_prep' into…
Jul 11, 2023
d2966a1
patch back over to reliance on ProfileSettings rather than html
Jul 12, 2023
ab1e6a4
conditional showing of log uploads
Jul 12, 2023
3b123e8
formatting modals with elevation
Jul 12, 2023
0bdd36c
migrated show OpCode!
Jul 12, 2023
e8faa6f
create alertbar to use instead of ionic popups
Jul 12, 2023
810a293
SettingRow: prevent duplicate action() call
JGreenlee Jul 14, 2023
ba0c101
ProfileSettings: track collectSettings w/ useState
JGreenlee Jul 14, 2023
8d76706
general-settings: remove $scope.settings.collect
JGreenlee Jul 14, 2023
bfac9c8
profile settings: tweak styling
JGreenlee Jul 14, 2023
32b4254
ProfileSettings: rename variable 'mainControlEl'
JGreenlee Jul 14, 2023
19fa99f
remove unused props from <profile-settings>
JGreenlee Jul 14, 2023
c75d732
fix userData dropdown
Jul 14, 2023
f7da968
remove unused imports
Jul 14, 2023
26fc5c3
fix qrSharing
Jul 14, 2023
d9afec8
removal of converted code
Jul 14, 2023
3f86035
formatting opcode popup
Jul 14, 2023
5ae257b
convert forceState
Jul 14, 2023
1b05012
formatting popups
Jul 14, 2023
78620af
formatting
Jul 14, 2023
3bfa277
migrate notificationSettings
Jul 17, 2023
3d2c9a9
add react native paper dates for reminder time
Jul 17, 2023
ac2d936
formatting TimePickerModal
Jul 17, 2023
9a639ca
cleaning up code
Jul 17, 2023
04d39b6
Merge pull request #5 from Abby-Wheelis/profile-migration-fixes
Abby-Wheelis Jul 17, 2023
43a7ef8
remove old time picker
Jul 18, 2023
cae522a
formatting profile
Jul 18, 2023
4c9f22e
remove no longer needed angularize calls
Jul 18, 2023
ab00bb7
update styles for titles
Jul 18, 2023
d415679
remove unused modules
Jul 19, 2023
0bcd303
fix notification schedule
Jul 19, 2023
6764359
leverage promise on initial load
Jul 19, 2023
017e703
make ReminderTime conditionally visible
Jul 20, 2023
2aee6ae
conditionally show schedule
Jul 20, 2023
7d51924
refactor fetching notifs to ensure scheduled first
Jul 20, 2023
c2c44ff
cleaning up code
Jul 20, 2023
fdf8907
remove .then()
Jul 20, 2023
c46de40
culling i18n files
Jul 28, 2023
3907088
Merge remote-tracking branch 'upstream/framework_migration_prep' into…
Aug 2, 2023
3e2ec44
remove game keys
Aug 8, 2023
cc8d77b
aria: hide leafletview from tree & label as "map"
JGreenlee Aug 11, 2023
5ef98cb
replace non-clickable <IconButton>s with <Icon>s
JGreenlee Aug 11, 2023
29d951d
wrap LabelDetailsScreen in <Modal>
JGreenlee Aug 11, 2023
1a0abae
aria: add labels, roles to DiaryCard components
JGreenlee Aug 11, 2023
5970f89
aria: add accessibilityLabels to Header components
JGreenlee Aug 11, 2023
e24989f
create EnketoModal.tsx
JGreenlee Aug 14, 2023
7e04637
finish implementation of EnketoModal
JGreenlee Aug 15, 2023
4341f4c
logger.js -> logger.ts
JGreenlee Aug 15, 2023
55cf019
add functions to logger.ts + use in EnketoModal
JGreenlee Aug 15, 2023
3745535
add more levels to logger, also add types
JGreenlee Aug 15, 2023
e084b59
add caching for loading surveys
JGreenlee Aug 15, 2023
fd1ee53
remove ReactHello.jsx
JGreenlee Aug 15, 2023
b48196b
tweak enketo styles for new EnketoModal
JGreenlee Aug 15, 2023
4cf9f58
Icon refactor, support other IconButton props too
JGreenlee Aug 15, 2023
4796626
LabelDetailsScreen: UI fixes, accessibility fixes
JGreenlee Aug 15, 2023
aaf6c06
use Dialogs for multilabel popups
JGreenlee Aug 15, 2023
a72fd4f
EnketoModal: tweak "Dismiss" and "Save" buttons
JGreenlee Aug 15, 2023
473bf6c
survey.js -> survey.ts
JGreenlee Aug 16, 2023
6b6db8b
refactor SurveyOptions to TypeScript
JGreenlee Aug 16, 2023
d81ba67
EnketoModal: receive click events on <button>s
JGreenlee Aug 16, 2023
0b59436
diary.js don't depend 'emission.survey'
JGreenlee Aug 16, 2023
81b882f
Merge branch 'framework_migration_prep' into label-improvements-aug-2023
JGreenlee Aug 16, 2023
e1c13a3
UserInputButton: use new EnketoModal
JGreenlee Aug 16, 2023
efb9e50
EnketoModal: make survey take up full height
JGreenlee Aug 16, 2023
12f81b2
AdedNotesList: use new EnketoModal
JGreenlee Aug 16, 2023
686cf4e
convert "confirm edit" popup to React Native Modal
JGreenlee Aug 16, 2023
65637a6
TimestampBadge.jsx -> TimestampBadge.tsx
JGreenlee Aug 16, 2023
4e09b5b
switch to TS typings on non-angularized components
JGreenlee Aug 16, 2023
011d9ba
bump react-native-web to ^0.19
JGreenlee Aug 18, 2023
cc991e6
create new confirmHelper.ts
JGreenlee Aug 18, 2023
8f6c778
use confirmHelper instead of Angular ConfirmHelper
JGreenlee Aug 18, 2023
da3d27c
remove trip-confirm-services.js
JGreenlee Aug 18, 2023
1b5e519
adjust DiaryButton UI
JGreenlee Aug 18, 2023
aab2c13
fix ui_config references in multi-label-ui
JGreenlee Aug 18, 2023
83cd604
fix translations
JGreenlee Aug 18, 2023
7f2bed8
try locally hosted configs on __DEV__, & refactor
JGreenlee Aug 18, 2023
aa996b2
Merge pull request #994 from Abby-Wheelis/More-Profile-Migrations
shankari Aug 19, 2023
1bf3312
restore "error-loading" key
Aug 19, 2023
e60341e
"subgroup no default error"
Aug 19, 2023
86288e6
🔨 Add additional build script options
shankari Aug 19, 2023
b17f094
🔨 Change the android build scripts to use `npm run`
shankari Aug 19, 2023
8471472
🔨 Add a script to create an app zip of the current release
shankari Aug 19, 2023
baa9af3
found missing key
Aug 19, 2023
3d2e1b9
Merge pull request #1008 from Abby-Wheelis/filter-i18n-keys
shankari Aug 19, 2023
faa1cfa
⬆️ Bump up the core versions
shankari Aug 19, 2023
7688caf
⬆️ 🔥 Bump up the platform version + remove override workaround
shankari Aug 20, 2023
76c4154
DiaryHelper: remove getNominatimLocName
JGreenlee Aug 20, 2023
8f75fe0
finish rewriting DiaryHelper
JGreenlee Aug 20, 2023
6a654ae
implement useDerivedProperties
JGreenlee Aug 20, 2023
364d1c4
unify imperial miles/km functions
JGreenlee Aug 20, 2023
33f7758
refactor into StartEndLocations.tsx
JGreenlee Aug 20, 2023
f1a905a
give unloaded address names default value ''
JGreenlee Aug 20, 2023
edd4ccf
make draft colors grey, not green
JGreenlee Aug 20, 2023
616a439
on load config, cache resources referenced by URL
JGreenlee Aug 20, 2023
1cf7e42
commit diaryTypes.ts [WIP]
JGreenlee Aug 20, 2023
e4f3af4
DiaryButton truncate overflow with ellipsis
JGreenlee Aug 21, 2023
423dbf6
fix dynamic config loading in dev environments
JGreenlee Aug 21, 2023
a5f8fab
Merge pull request #1016 from shankari/upgrade_android_api_33
shankari Aug 21, 2023
fc32101
Merge pull request #1014 from JGreenlee/label-improvements-aug-2023
shankari Aug 22, 2023
b13fd3f
Merge pull request #1019 from e-mission/maint_upgrade_2023
shankari Aug 22, 2023
50bbd80
fix: add explicit annotations to logger.ts
JGreenlee Aug 22, 2023
b9508cc
Merge pull request #1020 from JGreenlee/fix-annotations-logger
shankari Aug 22, 2023
8d82de3
remove .options from mode options retrieval
Aug 23, 2023
9579012
Merge pull request #1021 from Abby-Wheelis/staging_dashboard_error_fix
shankari Aug 23, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions bin/gen_release_app_zip.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
#!/bin/bash

PROJECT=$1
VERSION=$2

pushd platforms/ios/build/emulator
zip -o ../../../../$PROJECT-build-$VERSION.app.zip -r NREL\ OpenPATH.app
popd
2 changes: 1 addition & 1 deletion bin/sign_and_align_keys.sh
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ fi

# Sign and release the L+ version
# Make sure the highest supported version has the biggest version code
npx cordova build android --release -- --minSdkVersion=22
npm run build-prod-android
# cp platforms/android/app/build/outputs/apk/release/app-release-unsigned.aab platforms/android/app/build/outputs/apk/app-release-signed-unaligned.apk
jarsigner -verbose -sigalg SHA256withRSA -digestalg SHA-256 -keystore ../config_files/production.keystore ./platforms/android/app/build/outputs/bundle/release/app-release.aab androidproductionkey
cp platforms/android/app/build/outputs/bundle/release/app-release.aab $1-build-$2.aab
Expand Down
3 changes: 0 additions & 3 deletions config.cordovabuild.xml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
<preference name="webviewbounce" value="false" />
<preference name="UIWebViewBounce" value="false" />
<preference name="DisallowOverscroll" value="true" />
<preference name="android-minSdkVersion" value="22" />
<preference name="BackupWebStorage" value="none" />
<preference name="emSensorDataCollectionProtocolApprovalDate" value="2016-07-14" />
<preference name="GradlePluginGoogleServicesEnabled" value="true" />
Expand Down Expand Up @@ -48,8 +47,6 @@
</platform>
<platform name="android">
<hook src="hooks/before_build/android/android_copy_locales.js" type="before_build" />
<preference name="android-minSdkVersion" value="23" />
<preference name="android-targetSdkVersion" value="32" />
<preference name="AndroidLaunchMode" value="singleInstance"/>
<preference name="AndroidXEnabled" value="true" />
<preference name="GradlePluginKotlinEnabled" value="true" />
Expand Down
13 changes: 8 additions & 5 deletions package.cordovabuild.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,10 @@
"build": "npx webpack --config webpack.prod.js && npx cordova build",
"build-dev": "npx webpack --config webpack.dev.js && npx cordova build",
"build-dev-android": "npx webpack --config webpack.dev.js && npx cordova build android",
"build-dev-ios": "npx webpack --config webpack.dev.js && npx cordova build ios"
"build-dev-ios": "npx webpack --config webpack.dev.js && npx cordova build ios",
"build-prod-android": "npx webpack --config webpack.prod.js && npx cordova build android",
"build-prod-ios": "npx webpack --config webpack.prod.js && npx cordova build ios",
"build-prod-android-release": "npx webpack --config webpack.prod.js && npx cordova build android --release"
},
"devDependencies": {
"@babel/core": "^7.21.3",
Expand Down Expand Up @@ -115,22 +118,22 @@
"chart.js": "^4.3.0",
"chartjs-adapter-luxon": "^1.3.1",
"chartjs-plugin-annotation": "^3.0.1",
"cordova-android": "11.0.0",
"cordova-android": "12.0.0",
"cordova-ios": "6.2.0",
"cordova-plugin-advanced-http": "3.3.1",
"cordova-plugin-androidx-adapter": "1.1.3",
"cordova-plugin-app-version": "0.1.14",
"cordova-plugin-customurlscheme": "5.0.2",
"cordova-plugin-device": "2.1.0",
"cordova-plugin-em-datacollection": "git+https://github.com/e-mission/e-mission-data-collection.git#v1.7.8",
"cordova-plugin-em-datacollection": "git+https://github.com/e-mission/e-mission-data-collection.git#v1.7.9",
"cordova-plugin-em-opcodeauth": "git+https://github.com/e-mission/cordova-jwt-auth.git#v1.7.2",
"cordova-plugin-em-server-communication": "git+https://github.com/e-mission/cordova-server-communication.git#v1.2.6",
"cordova-plugin-em-serversync": "git+https://github.com/e-mission/cordova-server-sync.git#v1.3.2",
"cordova-plugin-em-settings": "git+https://github.com/e-mission/cordova-connection-settings.git#v1.2.3",
"cordova-plugin-em-unifiedlogger": "git+https://github.com/e-mission/cordova-unified-logger.git#v1.3.6",
"cordova-plugin-em-usercache": "git+https://github.com/e-mission/cordova-usercache.git#v1.1.6",
"cordova-plugin-email-composer": "git+https://github.com/katzer/cordova-plugin-email-composer.git#0.10.1",
"cordova-plugin-file": "7.0.0",
"cordova-plugin-file": "8.0.0",
"cordova-plugin-inappbrowser": "5.0.0",
"cordova-plugin-ionic-keyboard": "2.2.0",
"cordova-plugin-ionic-webview": "5.0.0",
Expand Down Expand Up @@ -165,7 +168,7 @@
"react-native-safe-area-context": "^4.6.3",
"react-native-screens": "^3.22.0",
"react-native-vector-icons": "^9.2.0",
"react-native-web": "^0.18.10",
"react-native-web": "^0.19.7",
"react-native-web-webview": "^1.0.2",
"react-qr-code": "^2.0.11",
"shelljs": "^0.8.5"
Expand Down
2 changes: 1 addition & 1 deletion package.serve.json
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@
"react-native-safe-area-context": "^4.6.3",
"react-native-screens": "^3.22.0",
"react-native-vector-icons": "^9.2.0",
"react-native-web": "^0.18.10",
"react-native-web": "^0.19.7",
"react-native-web-webview": "^1.0.2",
"react-qr-code": "^2.0.11",
"shelljs": "^0.8.5"
Expand Down
23 changes: 10 additions & 13 deletions www/css/style.css
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,16 @@
/* if we don't contain them here, they will leak into the rest of the app */
.enketo-plugin {
@import 'enketo-core/src/sass/formhub/formhub.scss';
flex: 1;
.question.non-select {
display: inline-block;
}
.question input[name*="_date"],
.question input[name*="_time"] {
width: calc(40vw - 10px);
margin-right: 5px;
display: flex;
}
}

.enketo-plugin .form-header {
Expand Down Expand Up @@ -1471,16 +1481,3 @@ svg {
width: 3ch;
left: calc(8px + 2.5ch);
}

.enketo-plugin .question.inline-datetime > input[name*="_date"],
.enketo-plugin .question.inline-datetime > input[name*="_time"] {
display: flex;
width: auto;
min-width: 65%;
max-width: 85%;
}

.enketo-plugin .question.inline-datetime {
display: inline-grid;
width: 50%;
}
Loading