🚑 🐛 Staging dashboard error fix #1021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The use of .options on these lines was always resulting in modeOptions and therefore the customMETs an CustomFootprint in being undefined. This was breaking and causing errors on the dashboard on staging.
shankari
changed the title
|
I think that this deserves an 🚑 ! |
shankari
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix the errors popping up on the dashboard on staging right now, which are also breaking the dashboard. You can see more about the investigation that led to this fix in the thread starting here.
I've now tested this fix on all 4 of my opCodes (including my personal nrel commute) and have not seen errors on any of them. I tested on NREL commute since the dashboard is working on my personal phone, and I wanted to make sure that the values were correct - the carbon and distances match exactly, calories are different, but that is because I have userData on my phone but not on the emulator.